-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ExecutionOutcome
generic over receipt collection type
#11108
Comments
Executor::receipts_root_slow
ExecutionOutcome
generic over Receipt
ExecutionOutcome
generic over Receipt
ExecutionOutcome
generic over receipt type
ExecutionOutcome
generic over receipt typeExecutionOutcome
generic over receipt collection type
@emhane I'm sure it'll make more sense as I dig in 😅 I can give it a crack, I'm sure I'll have more questions as I go |
hey @garwahl did you start with this? will scope this out into smaller issues otherwise. would like to point out that the sketch of the solution in the description uses a vector of receipts with bloom, when it should actually be a vector of vectors of receipts (without bloom). |
Hey not yet, no worries feel free to break it up into smaller tasks and I'll jump on those |
@emhane is this still ongoing? Happy to take a look into it |
Describe the feature
Make
ExecutionOutcome
generic over receipt collection. Require trait boundExecutionOutcome<T: Receipts>
inAutoSealBuilder
, in order to remove optimism feature from theAutoSealBuilder
. Somehow theExecutionOutcome
must be linked to theExecutor
so it can be customised at sdk level instead, probably requiring trait boundExecutor<Output: Into<ExecutionOutcome<T: Receipts>>>
.The trait
Receipts
doesn't exist yet, and needs to be smthg likeso the optimism receipts collection would have to look smthg like
and simple ethereum type
Additional context
No response
Tasks
The text was updated successfully, but these errors were encountered: