How to use a custom PrecompileProvider::run() function other than the one implemented inside PrecompilesMap?

[debjit-bw]

The PrecompilesMap has a run function implemented:

fn run(
    &mut self,
    context: &mut CTX,
    address: &Address,
    inputs: &InputsImpl,
    _is_static: bool,
    gas_limit: u64,
) -> Result<Option<InterpreterResult>, String> {
    // Get the precompile at the address
    let precompile = self.get(address);

    ...

And this type is hardcoded in ConfigureEvm:

pub trait ConfigureEvm: Clone + Debug + Send + Sync + Unpin {
    ...
    type BlockExecutorFactory: BlockExecutorFactory<
        Transaction = TxTy<Self::Primitives>,
        Receipt = ReceiptTy<Self::Primitives>,
        EvmFactory: EvmFactory<
            Tx: TransactionEnv
                    + FromRecoveredTx<TxTy<Self::Primitives>>
                    + FromTxWithEncoded<TxTy<Self::Primitives>>,
            Precompiles = PrecompilesMap,   // <<< HERE <<<
        >,
    >;

Even though I have implemented a fn run(&mut self, context: &mut CTX, ...) in the impl<CTX> PrecompileProvider<CTX> for CustomPrecompiles , and used this CustomPrecompile in:

pub struct CustomEvm<DB: Database, I, P = CustomPrecompiles>

and 

pub struct CustomEvm<CTX, INSP, I = EthInstructions<EthInterpreter, CTX>, P = CustomPrecompiles>

The custom run() function never gets called. The customization I want is essentially, to pass in the inputs.input as well as the inputs.caller_address to the precompile. But right now, the custom run() function is not getting triggered.

Should we change the Precompiles = PrecompilesMap into an impl? Or is there an other suggested way?

[mattsse]

@klkvr I think for this we need to offload the features we currently rely on on the PrecompilesMap to a trait that we add to type Precompiles;?

[debjit-bw]

I'm preparing a PR to alloy-evm which moves the map_precompile(s) to a trait. Will allow us to drop the hardcoded PrecompilesMap in ConfigureEvm

[debjit-bw]

alloy-rs/evm#102

[klkvr]

@debjit-bw would your usecase be covered by extending the Precompile::call method with caller address?

https://github.com/alloy-rs/evm/blob/3723cbbb285a383e1412c1a8a17aa9423f5abb95/crates/evm/src/precompiles.rs#L274-L278

[debjit-bw]

hey @klkvr, yep it will. for more generalization, can we pass in the whole inputs struct to the precompile's call?

[debjit-bw]

hi, any update on this? i think alloy-rs/evm#102 is a better (long term) way of doing it, as having the trait bound at the evm level allows us to remove the Precompiles = PrecompilesMap, from ConfigureEvm::BlockExecutorFactory::EvmFactory.