From 431860ef80d3aef561740b7e59b4eff466bfd42c Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Fri, 10 May 2024 13:09:48 -0700 Subject: [PATCH] Remove conditional that will never happen --- .../app-frame/global-search/global-search.component.spec.ts | 5 +---- .../app-frame/global-search/global-search.component.ts | 2 -- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src-ui/src/app/components/app-frame/global-search/global-search.component.spec.ts b/src-ui/src/app/components/app-frame/global-search/global-search.component.spec.ts index bf207c75fec..54ea735b65d 100644 --- a/src-ui/src/app/components/app-frame/global-search/global-search.component.spec.ts +++ b/src-ui/src/app/components/app-frame/global-search/global-search.component.spec.ts @@ -249,10 +249,7 @@ describe('GlobalSearchComponent', () => { expect(blurSpy).toHaveBeenCalled() component.searchResults = { total: 1 } as any - component.resultsDropdown.close() - const openSpy = jest.spyOn(component.resultsDropdown, 'open') - component.searchInputKeyDown(new KeyboardEvent('keydown', { key: 'Enter' })) - expect(openSpy).toHaveBeenCalled() + component.resultsDropdown.open() component.searchInputKeyDown( new KeyboardEvent('keydown', { key: 'ArrowDown' }) diff --git a/src-ui/src/app/components/app-frame/global-search/global-search.component.ts b/src-ui/src/app/components/app-frame/global-search/global-search.component.ts index b10cf7f7184..2b1a078c454 100644 --- a/src-ui/src/app/components/app-frame/global-search/global-search.component.ts +++ b/src-ui/src/app/components/app-frame/global-search/global-search.component.ts @@ -277,8 +277,6 @@ export class GlobalSearchComponent implements OnInit { } else if (this.query?.length) { this.runAdvanedSearch() this.reset(true) - } else if (this.searchResults?.total && !this.resultsDropdown.isOpen()) { - this.resultsDropdown.open() } } else if (event.key === 'Escape' && !this.resultsDropdown.isOpen()) { if (this.query?.length) {