Char and int comparison

[616slayer616]

Line 51 is never true for all the examples I put into it.

natorder/NaturalOrderComparator.java

Line 51 in ab9e2df

if (ca == 0 && cb == 0) {

Is it supposed to compare with 0 (space) or with 48 (0)?

if (ca == '0' && cb == '0') {

[616slayer616]

The condition cannot evaluate to true because of

natorder/NaturalOrderComparator.java

Line 42 in ab9e2df

if (!Character.isDigit(ca) && !Character.isDigit(cb)) {

If both ca and cb are 0 (space, non-digit) bias will be returned.

So L51 is either redundant or should be changed to check for 48 or '0' respectively

[paour]

The line is indeed redundant: if both ca and cb are 0, then neither is a digit.

[616slayer616]

Thank you for the clarification

[paour]

Fixed by #9

[616slayer616]

This is the wrong issue for PR #9

I have no PR for the redundancy issue because I was unsure.

PR #9 is for Issue #1