Skip to content

Binder Links Inconsistent Between Gallery Repo and Individual Notebooks #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
salvis2 opened this issue Jun 24, 2020 · 0 comments
Open

Comments

@salvis2
Copy link

salvis2 commented Jun 24, 2020

On the gallery website, you can go into any of the sets of examples backed by a repo and open up the repo in the binderhub that was specified in binder-gallery.yaml. This launches into the binderhub and appears all fine and dandy. I was checking links for pangeo-tutorial-gallery. The binder link for pangeo-tutorial-gallery is:

https://aws-uswest2-binder.pangeo.io/v2/gh/pangeo-data/pangeo-tutorial-gallery/binder-env?urlpath=git-pull?repo=https://github.com/pangeo-data/pangeo-tutorial-gallery%26amp%3Burlpath=lab/tree/pangeo-tutorial-gallery

If you click into one of the notebooks (for my example, say, Geopandas) within the gallery website, there is a binder link in the sidebar. However, it does not work properly. The link in this case is

https://aws-uswest2-binder.pangeo.io/v2/gh/pangeo-data/pangeo-tutorial-gallery/master/?urlpath=git-pull?repo=https://github.com/pangeo-data/pangeo-tutorial-gallery%26amp%3Burlpath=lab/tree/pangeo-tutorial-gallery/geopandas.ipynb%3Fautodecode

I made a different branch for the environment, so I wasn't sure if that was part of the problem. I can see that the notebook link starts from master instead of binder-env, where I put the environment information.

Trying the individual links for the Enhanced Intake-ESM Catalog Demo within the CESM LENS gallery and the individual link @TomAugspurger 's Pangeo and Dask Gateway gallery notebook both worked fine. The LENS gallery references it's own image setup in the same repo and branch as the notebooks and the Pangeo / Dask gallery references the pangeo-gallery default-binder.

So clearly I have been silly with making a new branch, but it this something that we should build support for, or do we want to specifically note that your binder/ folder, if you are specifying it, should also be in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant