Delete Vault generated keys #638
Open
+47
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do this on teardown instead? |
|
@kenany Done. I've done it on class method because I don't think it make sense to run it after every tests. Is that okey? |
kenany
reviewed
Feb 27, 2025
Comment on lines
-756
to
-759
| def test_list(self) -> None: | ||
| list_resp = self.vault.list() | ||
| assert list_resp.result | ||
| self.assertGreater(len(list_resp.result.items), 0) |
There was a problem hiding this comment.
Don't we want to continue testing Vault's list endpoint, though? I know it's called in the new teardown, but I still feel like it deserves its own tests with assertions (ever if only this assertGreater(len(list_resp.result.items), 0) one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.