Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Python fallback for Cythonized groupby transformations #49758

Open
rhshadrach opened this issue Nov 17, 2022 · 0 comments · May be fixed by #58639
Open

ENH: Python fallback for Cythonized groupby transformations #49758

rhshadrach opened this issue Nov 17, 2022 · 0 comments · May be fixed by #58639
Labels
Enhancement Groupby

Comments

@rhshadrach
Copy link
Member

Ref: #49742 (comment)

Within the groupby code, when the Cython portion of _cython_agg_general encounters a NotImplementedError, it falls back to _agg_py_fallback. The method _cython_transform currently has no such fallback, and so trying to use e.g. cummin on string columns fails. I think we should instead provide a Python fallback.
@undermyumbrella1 undermyumbrella1 linked a pull request May 8, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Groupby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enh/transform py fallback undermyumbrella1/pandas
1 participant
@rhshadrach