Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ontology Rid should be optional #279

Closed
ewitkon opened this issue May 6, 2024 · 4 comments
Closed

Ontology Rid should be optional #279

ewitkon opened this issue May 6, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ewitkon
Copy link
Contributor

ewitkon commented May 6, 2024

When using createClient we should allow developer not to pass an ontology Rid for cases where the client use used to access resource not bounded to the ontology like Datasets.

ontologyRid: string,

@ericanderson
Copy link
Member

Note to self, either implement this as:

  • createOntologyClient and createClient
  • createClient optionally takes an ontology rid, and thus calls to client() would take a second parameter for an ontology rid. Also could implement this as client.withOntology(rid).

@ericanderson ericanderson self-assigned this May 9, 2024
@ericanderson ericanderson added this to the 2.x milestone May 9, 2024
@ericanderson
Copy link
Member

Likely blocks on #299

@ericanderson ericanderson added the enhancement New feature or request label May 9, 2024
@ericanderson
Copy link
Member

Also related: #301

@ericanderson
Copy link
Member

Closing in favor of #375

@ericanderson ericanderson modified the milestones: 2.x, 2.0.0 Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants