Skip to content

chore: [IOAPPX-463] Enable full support for edge-to-edge navigation on Android #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmnplb merged 71 commits into from
Jan 8, 2026
Merged

chore: [IOAPPX-463] Enable full support for edge-to-edge navigation on Android #6602

dmnplb merged 71 commits into from
Jan 8, 2026
+979 −551

Conversation

@dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 14, 2025 •
edited
Loading

Important

This PR depends on:

Short description

This PR enables full support for edge-to-edge navigation on Android.

List of changes proposed in this pull request

  • Enable full support for edge-to-edge navigation by updating MainActivity.kt file
  • Enable support for edge-to-edge navigation by setting edgeToEdgeEnabled to true (RN 0.81 and above)
  • Fix splash screen ugly rectangles in both gesture and button navigation modes
  • Remove ugly white rectangle at the top of the BarcodeScanScreen
  • Remove ugly white rectangle at the top of the ServiceDetail screen
  • Update react-native-safe-area-context to the latest version

⚠️ Known issues

  • When gesture navigation mode is on, the inset padding won't be set correctly. This means:
  • There's still a white rectangle at the bottom of the IdentificationModal
  • When the button mode is enabled, the navigation bar will have an opaque black background instead of the light grey background it had before.

Note

These issues appear to be caused by the react-native-safe-area-context package not handling the insets properly:

Preview

Splash screen

Before

Button mode Gesture mode
splash-screen-legacy splash-screen-edge-new

After

Button mode Gesture mode
Screenshot_20250114_123211 Screenshot_20250114_121630

Barcode Scan

Before After
barcode-screen-leg-edge barcode-screen-edge-new

Service Detail

Before After
service-detail-legacy-edge service-detail-edge-new

Related tech docs

How to test

  1. Run the app on Android
  2. Change navigation mode between button mode and gesture mode
  3. Navigate through the app to check that everything is working correctly

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited by atlassian bot
Loading

Jira Pull Request Link

This Pull Request refers to Jira issues:

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter 💅 Visual tweaks labels Jan 14, 2025
@dmnplb dmnplb linked an issue Jan 14, 2025 that may be closed by this pull request
Enable Edge to edge - Android 15 #6599
Closed
@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.96%. Comparing base (0584e11) to head (a95a893).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...preferences/screens/AppearancePreferenceScreen.tsx 20.00% 8 Missing ⚠️
ts/hooks/useAppThemeConfiguration.tsx 0.00% 8 Missing ⚠️
ts/utils/hooks/bottomSheet.tsx 33.33% 8 Missing ⚠️
...endesk/screens/ZendeskAskSeeReportsPermissions.tsx 0.00% 1 Missing ⚠️
ts/navigation/AuthenticatedStackNavigator.tsx 0.00% 1 Missing ⚠️
ts/navigation/NotAuthenticatedStackNavigator.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6602      +/-   ##
==========================================
- Coverage   59.98%   59.96%   -0.02%     
==========================================
  Files        1905     1905              
  Lines       41783    41803      +20     
  Branches     9677     9619      -58     
==========================================
+ Hits        25064    25068       +4     
- Misses      16635    16661      +26     
+ Partials       84       74      -10
Files with missing lines Coverage Δ
...entication/login/landing/screens/LandingScreen.tsx 73.68% <ø> (-0.55%) ⬇️
...code/components/BarcodeScanBaseScreenComponent.tsx 86.44% <ø> (-0.23%) ⬇️
ts/features/design-system/core/DSLoaders.tsx 45.45% <ø> (ø)
...res/identification/screens/IdentificationModal.tsx 64.74% <ø> (-0.23%) ⬇️
...features/zendesk/screens/ZendeskAskPermissions.tsx 87.50% <100.00%> (+0.14%) ⬆️
...features/zendesk/screens/ZendeskChooseCategory.tsx 70.96% <100.00%> (+0.96%) ⬆️
...tures/zendesk/screens/ZendeskChooseSubCategory.tsx 68.57% <100.00%> (+0.92%) ⬆️
...tures/zendesk/screens/ZendeskSupportHelpCenter.tsx 73.04% <100.00%> (+0.23%) ⬆️
ts/hooks/useFooterActionsMargin.tsx 100.00% <100.00%> (ø)
...endesk/screens/ZendeskAskSeeReportsPermissions.tsx 4.54% <0.00%> (-0.22%) ⬇️
... and 5 more

... and 12 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0584e11...a95a893. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CrisTofani
CrisTofani approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb added this pull request to the merge queue Jan 8, 2026
Merged via the queue into master with commit 6c35d5d Jan 8, 2026
23 checks passed
@dmnplb dmnplb deleted the IOAPPX-463-add-support-edge-to-edge-navigation branch January 8, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

@LeleDallas LeleDallas LeleDallas approved these changes

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

@RiccardoMolinari95 RiccardoMolinari95 Awaiting requested review from RiccardoMolinari95 RiccardoMolinari95 is a code owner

Assignees

No one assigned

Labels

Design System New visual language and reduction of previous UI clutter 💅 Visual tweaks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable Edge to edge - Android 15

4 participants

@dmnplb @LeleDallas @Bl4ckk98 @CrisTofani