-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow overwriting props #201
Comments
Would be very useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are many cases where it makes sense to override the props of the components.
Examples:
aria-label
of e.g.CommandLoading
andCommandList
to support multi languagearia-expanded
ofCommandInput
, which is alwaystrue
currently, but should only betrue
, when the input has focus or after typing, when the list is showntype
ofCommandInput
to let users only insert numbers for instanceThere is already a PR for it #117, but I created a new one #202
Here is a code sandbox, where we can see the problem
Maybe we can realize it?
The text was updated successfully, but these errors were encountered: