Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ditching codacy #334

Open
ajjackson opened this issue Dec 5, 2024 · 1 comment
Open

Consider ditching codacy #334

ajjackson opened this issue Dec 5, 2024 · 1 comment

Comments

@ajjackson
Copy link
Collaborator

ajjackson commented Dec 5, 2024

Codacy can be a bit of a nuisance as it involves an external service, API keys etc. This leads to e.g. "failing" CI for branches from external contributors.

Instead we could be running ruff and/or pylint in a Github action. The output is not quite as pretty, but simpler and more reliable to access.

The main thing it provides (via further complexity/failure-points) is a nice interface for the code coverage results. For testing we already have a nice little action/bot setup that writes high-level test results to a comment in the PR. Maybe we can do something similar for coverage data, and rely on local analysis for fancy HTML views?

@ajjackson ajjackson changed the title Ditch codacy Consider ditch codacy Dec 5, 2024
@ajjackson ajjackson changed the title Consider ditch codacy Consider ditching codacy Dec 5, 2024
@ajjackson
Copy link
Collaborator Author

I note that castep-outputs has recently added a more streamlined coverage report action:

oerc0122/castep_outputs#190

The main downside is that it generates a lot of email (but so does codacy with current config...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant