Support for scala 2.13?

[louisjiang]

Support for scala 2.13?

[leleuj]

Not yet. Feel free to submit a contribution.

[louisjiang]

Dependent on external project deadbolt-2-scala
mkurz/deadbolt-2-scala#50

[leleuj]

OK. Let's wait for that then.

[aeismann]

FYI: @louisjiang That dependency has moved forward now:
mkurz/deadbolt-2-scala#50

[pbyrne84]

Deadbolt scala does not look like it has been properly published for 2.11
https://repo1.maven.org/maven2/be/objectify/deadbolt-scala_2.11/2.7.1/
versus
https://repo1.maven.org/maven2/be/objectify/deadbolt-scala_2.13/2.7.1/

:(

Things seem to of been moved/renamed internally in deadbolt so it may be worth waiting for play 2.8 support as it looks like it has dropped 2.11 simplifying things.

[leleuj]

@pbyrne84 Just to be sure: you suggest to first move to Play 2.8 and then remove Scala 2.11 and add Scala 2.13, right?

[pbyrne84]

Sorry for not getting back sooner. Well the move to play 2.8 will remove 2.11 as it is no longer supported. The deadbolt changes would now block you and would require incompatible versions of deadbolts to be running across different Scala versions in your build. That does not sound like fun to me.

There is an issue raised for the missing 2.11 build
mkurz/deadbolt-2-scala#51
I assume it is right place as it mentions 2.7.1

[mkurz]

I released deadbolt 2.7.1 for Scala 2.11 now:
https://repo1.maven.org/maven2/be/objectify/deadbolt-scala_2.11/2.7.1/
Seems like a problem occured when released last year.

[mkurz]

Oh yes and deadbolt 2.8.0 for Scala 2.12 and 2.13 is released now as well. Have fun!

[leleuj]

Thanks

[leleuj]

@mkurz Just to be sure: for Play 2.7, I must use Deadbolt 2.7 and for Play 2.8, I must use Deadbolt 2.8, right?

[mkurz]

@leleuj Yes, that's correct.

[mkurz]

Because from deadbolt 2.7 to deadbolt 2.8 nothing really changed, you may be able to use deadbolt 2.7 with Play 2.8. I think that should work as well given that deadbolt 2.8 is just compiled against Play 2.8 without any changes in its source code. However the safest way is probably to just use deadbolt 2.8.
deadbolt 2.7 and deadbolt 2.8 do not differ in features or anything else, it's just recompiled.

[leleuj]

@mkurz Thanks for confirming this.

I was in v2.6.1 and I have compilation issues with v2.7.1. I guess things have changed: is there a migration guide somewhere to help me?

[mkurz]

Not really a migration guide, but maybe it helps: mkurz/deadbolt-2-java#89

[leleuj]

I saw this doc, but it won't be enough for me.

I have taken a look at the documentation (https://deadbolt-java.readme.io/) and I haven't been able to find the guide for a release after the version 2.6.3: am I missing something?

[leleuj]

OK. I see the problem: I'm relying on Http.Context which has been replaced by Http.RequestHeader. This is something I planned to do in play-pac4j even in Play 2.7, so I will start by that. The upgrade should be straightforward after that.

Thanks for your help.

[mkurz]

@leleuj If you need help along the way let me know.

[leleuj]

Thanks for proposing. Almost all work was on my side. As soon as I used RequestHeader instead of Http.Context, the Deadbolt upgrade became easy.

[mkurz]

Great!

[leleuj]

I just added the Scala 2.13 support as well.