Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tdi operations and notifications #126

Merged
merged 13 commits into from
Sep 12, 2023
Merged

Tdi operations and notifications #126

merged 13 commits into from
Sep 12, 2023
+856 −83

Conversation

satish153
Copy link
Contributor

notifications and operations support

@satish153 satish153 requested review from saynb and abhaysi2 May 29, 2023 08:59
saynb
saynb reviewed Jul 21, 2023
View reviewed changes
include/tdi/common/tdi_notifications.hpp Show resolved Hide resolved
src/c_frontend/tdi_table_notifications_c.cpp Outdated Show resolved Hide resolved
src/c_frontend/tdi_table_notifications_c.cpp Outdated Show resolved Hide resolved
src/c_frontend/tdi_table_notifications_c.cpp Outdated Show resolved Hide resolved
@satish153 satish153 requested a review from saynb September 7, 2023 02:03
saynb
saynb reviewed Sep 11, 2023
View reviewed changes
include/tdi/common/c_frontend/tdi_operations.h Show resolved Hide resolved
include/tdi/common/c_frontend/tdi_table.h Outdated Show resolved Hide resolved
src/c_frontend/tdi_table_operations_c.cpp Outdated Show resolved Hide resolved
src/tdi_table.cpp Outdated Show resolved Hide resolved
tdi_python/tdiTable.py Outdated Show resolved Hide resolved
tdi_python/tdiTable.py Show resolved Hide resolved
tdi_python/tdiTable.py Outdated Show resolved Hide resolved
saynb
saynb approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@saynb saynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please take care of the missed review comment and logging module usage in tdi_python instead of prints

include/tdi/common/c_frontend/tdi_operations.h Show resolved Hide resolved
tdi_python/tdiTable.py Outdated Show resolved Hide resolved
@satish153 satish153 merged commit 6d5bcfe into main Sep 12, 2023
2 checks passed
@saynb saynb deleted the tdi_operations_notifications branch September 12, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saynb saynb saynb approved these changes

@abhaysi2 abhaysi2 Awaiting requested review from abhaysi2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satish153 @saynb