Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running sar_update twice crashes the game #108

Open
SirWillian opened this issue Oct 25, 2022 · 2 comments
Open

Running sar_update twice crashes the game #108

SirWillian opened this issue Oct 25, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@SirWillian
Copy link

  • Be on latest release (1.12.7)
  • Run sar_update pre twice

Discovered by wanting to update from 1.12.7-pre5 (or some 1.12.7 prerelease) to some version with sar_dpi_scale. Ran sar_update first and then sar_update pre immediately after

Also replicated by running sar_update pre force twice while using the latest prerelease (1.12.8-pre2)

Seems like the crash happens after the second download is finished as I believe i can read "Deleting old version.." being printed to console a split second before it crashes

@ThisAMJ
Copy link
Member

ThisAMJ commented Oct 29, 2022

I can't repro on Linux (1.12.8-pre2)
As many as 7 sar_updates successfully ran

@mlugg
Copy link
Member

mlugg commented Nov 27, 2022

This happens because of the way updating on Windows has to work (because Windows is weird about deleting files that already exist). Running sar_update a second time causes the temporary file containing the old SAR version to get overwritten. The fix should be pretty simple though - I'll take a look soon,

@mlugg mlugg added the bug Something isn't working label Jan 15, 2023
ThisAMJ added a commit that referenced this issue Apr 6, 2023
Resolves: Running sar_update twice crashes the game #108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants