Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumbotron configuration upgrades #127

Open
2 tasks
beckymargraf opened this issue Sep 23, 2020 · 3 comments
Open
2 tasks

Jumbotron configuration upgrades #127

beckymargraf opened this issue Sep 23, 2020 · 3 comments

Comments

@beckymargraf
Copy link
Contributor

  • Ability to set jumbotron_image behavior as cover/scale-to-fit or tile
  • Ability to manually customize fill with hex color input (rather than a tinted transparent image)
@dirkcuys
Copy link
Member

My preference for course in a box is to simplify, ie. only provide 2 ways to configure the header:

A color OR a custom image

More options are possible, but goes into the realm of "here is how you can update the CSS to customize your header further ..."

@beckymargraf
Copy link
Contributor Author

Okay!

Should we remove the support for the mask in general and just encourage legibility consideration to whomever is designing the course and picking an image/color?

@GrifP
Copy link
Member

GrifP commented Jan 3, 2021

Related to this: if you remove the default image in the config file and don't replace it with anything else, it will still use the pattern background (rather than the expected result, which would be to not use any image). The workaround for now is to delete the pattern svg from the img folder and then ignore the error message you get when pushing changes, but that isn't intuititive.

Relatedly -- Jekyll needs to be relaunched for config changes to appear. So when we make updates we should reflect that in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants