fix removing breakpoints

oxinabox · Jul 13, 2019 · 0dc2d48 · 0dc2d48
1 parent 8642d1c
commit 0dc2d48
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/src/breakpoints.jl b/src/breakpoints.jl
@@ -41,9 +41,9 @@ for (name, list) in ((:breakpoint, :breakon_rules), (:uninstrumented, :no_instru
     @eval function $(rm!)(the_rules::BreakpointRules, args...)
         old_num_rules = length(the_rules.$list)
         to_remove = rules(args...)
-        filter!(x->x∈to_remove, the_rules.$list)
+        filter!(!in(to_remove), the_rules.$list)
         if length(the_rules.$list) == old_num_rules
-            @info("No matching $($name) was found, so none removed")
+            @info("No matching rule was found, so none removed")
         end
         return the_rules.$list
     end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -6,6 +6,7 @@ test_files = (
     "test_behavour.jl",
     "test_breadcrumbs.jl",
     "test_breakpoint_rules.jl",
+    "test_breakpoints.jl",
     "test_inner_repl.jl",
     "test_locate.jl",
     "test_method_utils.jl",

diff --git a/test/test_breakpoints.jl b/test/test_breakpoints.jl
@@ -0,0 +1,10 @@
+using MagneticReadHead
+using Test
+
+@testset "Should be able to add and remove breakpoints" begin
+    @test length(set_breakpoint!(Test)) == 1
+    @test length(rm_breakpoint!(Test)) == 0
+
+    @test length(set_uninstrumented!(Test)) == 1
+    @test length(rm_uninstrumented!(Test)) == 0
+end