-
Notifications
You must be signed in to change notification settings - Fork 58
Open
Milestone
Description
Re-uploading a TUF repo is idempotent with regards to the database, but the artifacts are dropped if the repo is already listed in the database:
omicron/nexus/src/app/update.rs
Lines 66 to 74 in 4d5bdc6
// If we inserted a new repository, move the `ArtifactsWithPlan` (which | |
// carries with it the `Utf8TempDir`s storing the artifacts) into the | |
// artifact replication background task, then immediately activate the | |
// task. | |
if response.status == TufRepoInsertStatus::Inserted { | |
self.tuf_artifact_replication_tx | |
.send(artifacts_with_plan) | |
.await | |
.map_err(|err| { |
If artifacts are lost from replication (most likely due to a Nexus crash/restart) there would be no way to reintroduce those artifacts, other than by manually injecting them into the update dataset. By removing this conditional operators can fix this.
Metadata
Metadata
Assignees
Labels
No labels