Skip to content

Commit 419175d

Browse files
committed
review addresses
Signed-off-by: nabim777 <[email protected]>
1 parent 9bfe0fb commit 419175d

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/web-app-progress-bars/tests/e2e/progressBar.spec.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ test.afterEach(async () => {
1313
await logout(adminPage)
1414
})
1515

16-
test('select the progressBarOption on the account page', async () => {
16+
test('select NyanCat progressBarOption on the account page', async () => {
1717
const accountPage = new AccountPage(adminPage)
1818
await accountPage.goToAccountPage()
19-
await accountPage.selectProgressBarExtension()
19+
await accountPage.selectNyanCatProgressBarExtension()
2020

2121
const progressBarCurrent = await accountPage.progressBarCurrent.textContent()
2222
expect(progressBarCurrent).toEqual('Nyan Cat progress bar')

support/pages/accountPage.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export class AccountPage {
66
readonly accountManageBtn: Locator
77
readonly progressBarSelector: Locator
88
readonly progressBarCurrent: Locator
9-
readonly progressBarOption: Locator
9+
readonly nyanCatProgressBarOption: Locator
1010

1111
constructor(page: Page) {
1212
this.page = page
@@ -15,17 +15,17 @@ export class AccountPage {
1515

1616
this.progressBarSelector = this.page.locator('.extension-preference .vs__search')
1717
this.progressBarCurrent = this.page.locator('.extension-preference .vs__selected span')
18-
this.progressBarOption = this.page.getByText('Nyan Cat progress bar')
18+
this.nyanCatProgressBarOption = this.page.getByText('Nyan Cat progress bar')
1919
}
2020

2121
async goToAccountPage() {
2222
await this.accountMenuBtn.click()
2323
await this.accountManageBtn.click()
2424
}
2525

26-
async selectProgressBarExtension(){
26+
async selectNyanCatProgressBarExtension(){
2727
await this.progressBarSelector.waitFor()
2828
await this.progressBarSelector.click()
29-
await this.progressBarOption.click()
29+
await this.nyanCatProgressBarOption.click()
3030
}
3131
}

0 commit comments

Comments
 (0)