Test: target REQUEST_COOKIES - 059 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airween
approved these changes
Jun 1, 2025
|
Approved, but please resolve the conflicts. |
Signed-off-by: Sebitosh <[email protected]>
Signed-off-by: Sebitosh <[email protected]>
Sebitosh
force-pushed
the
test-target-cookie
branch
from
d4a0b7c to
77b51ec
Compare
|
rebased & regenerated tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#27
Target test on REQUEST_COOKIES. Like for ARGS, we test cookies with various combinations (all, cookie1, cookie1 & cookie2, cookie regex). Went for this test as it the target is used 151 times in CRS 4.8.0 according to https://crsdoc.digitalwave.hu/?v=v4.8.0
I am unsure if this is entirely necessary, but for the request generation I added tests to confirm behavior when multiple cookies where specified (to ensure parsing multiple still works). For example, a test for the cookie regex has
cookie_bar=hello;cookie_foo=attack;cookie_foobar=worldto ensure the rule matches the cookie in the middle.Assessment on V2
All tests pass on V2
Assessment on V3 (using the not yet merged #24 infra)
All tests pass on V3