Merge remote-tracking branch 'overte/master' into application

Author: HifiExperiments

.github/workflows/linux_server_build.yml

@@ -82,16 +82,6 @@ jobs:
             arch: aarch64
             runner: [self_hosted, type-cax41, image-arm-app-docker-ce]
 
-          - os: fedora-39
-            image: docker.io/overte/overte-server-build:0.1.4-fedora-39-amd64
-            arch: amd64
-            runner: [self_hosted, type-cx52, image-x86-app-docker-ce]
-
-          - os: fedora-39
-            image: docker.io/overte/overte-server-build:0.1.4-fedora-39-aarch64
-            arch: aarch64
-            runner: [self_hosted, type-cax41, image-arm-app-docker-ce]
-
           - os: fedora-40
             image: docker.io/overte/overte-server-build:0.1.4-fedora-40-amd64
             arch: amd64
@@ -224,10 +214,6 @@ jobs:
         else  # RPM
           if [ "${{ matrix.os }}" == "rockylinux-9" ]; then
             echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.el9.$INSTALLER_EXT" >> $GITHUB_ENV
-          elif [ "${{ matrix.os }}" == "fedora-38" ]; then
-            echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.fc38.$INSTALLER_EXT" >> $GITHUB_ENV
-          elif [ "${{ matrix.os }}" == "fedora-39" ]; then
-            echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.fc39.$INSTALLER_EXT" >> $GITHUB_ENV
           elif [ "${{ matrix.os }}" == "fedora-40" ]; then
             echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.fc40.$INSTALLER_EXT" >> $GITHUB_ENV
           else
@@ -266,7 +252,7 @@ jobs:
 
     - name: Archive cmake logs
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: cmake-logs-${{ matrix.os }}-${{ matrix.arch }}-${{ github.event.number }}.tar.xz
         path: cmake-logs-${{ matrix.os }}-${{ matrix.arch }}-${{ github.event.number }}.tar.xz

.github/workflows/master_build.yml

@@ -65,7 +65,7 @@ jobs:
       run: |
 
         echo "UPLOAD_PREFIX=build/overte/master" >> $GITHUB_ENV
-        echo ::set-output name=github_sha_short::`echo $GIT_COMMIT | cut -c1-7`
+        echo "{github_sha_short}={`echo $GIT_COMMIT | cut -c1-7`}" >> $GITHUB_OUTPUT
         echo "JOB_NAME=build (${{matrix.os}}, ${{matrix.build_type}})" >> $GITHUB_ENV
         echo "APP_TARGET_NAME=$APP_NAME" >> $GITHUB_ENV
         # Linux build variables
@@ -82,7 +82,7 @@ jobs:
           echo "ZIP_ARGS=-r" >> $GITHUB_ENV
           echo "INSTALLER_EXT=dmg" >> $GITHUB_ENV
           echo "CMAKE_EXTRA=-DOVERTE_CPU_ARCHITECTURE= -DCMAKE_OSX_SYSROOT=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk -DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DOPENSSL_LIBRARIES=/usr/local/opt/openssl/lib -G Xcode" >> $GITHUB_ENV
-          echo "::set-output name=symbols_archive::${BUILD_NUMBER}-${{ matrix.build_type }}-mac-symbols.zip"
+          echo "symbols_archive=${BUILD_NUMBER}-${{ matrix.build_type }}-mac-symbols.zip" >> $GITHUB_ENV
           echo "APP_TARGET_NAME=Overte" >> $GITHUB_ENV
         fi
         # Windows build variables
@@ -91,7 +91,7 @@ jobs:
           echo "ZIP_COMMAND=7z" >> $GITHUB_ENV
           echo "ZIP_ARGS=a" >> $GITHUB_ENV
           echo "INSTALLER_EXT=exe" >> $GITHUB_ENV
-          echo "CMAKE_EXTRA=-A x64" >> $GITHUB_ENV
+          echo "CMAKE_EXTRA=-A x64 -DJSDOC_ENABLED:BOOL=TRUE" >> $GITHUB_ENV
           echo "SYMBOL_REGEX=\(exe\|dll\|pdb\)" >> $GITHUB_ENV
           echo "symbols_archive=${BUILD_NUMBER}-${{ matrix.build_type }}-win-symbols.zip" >> $GITHUB_ENV
           # echo "HF_PFX_PASSPHRASE=${{secrets.pfx_key}}" >> $GITHUB_ENV

.github/workflows/master_deploy_apidocs.yml

@@ -31,7 +31,7 @@ jobs:
         jsdoc root.js -r api-mainpage.md -c config.json -d output
 
     - name: Deploy API-docs
-      uses: SamKirkland/[email protected].4
+      uses: SamKirkland/[email protected].5
       with:
         server: www531.your-server.de
         protocol: ftps

.github/workflows/master_deploy_doxygen.yml

@@ -29,7 +29,7 @@ jobs:
         doxygen Doxyfile
 
     - name: Deploy Doxygen
-      uses: SamKirkland/[email protected].4
+      uses: SamKirkland/[email protected].5
       with:
         server: www531.your-server.de
         protocol: ftps

.github/workflows/pr_build.yml

@@ -64,8 +64,8 @@ jobs:
               runner: [self_hosted, type-cx52, image-x86-app-docker-ce]
               arch: amd64
               build_type: full
-              apt-dependencies: pkg-config libxext-dev libdouble-conversion-dev libpcre2-16-0 libpulse0 libharfbuzz-dev libnss3 libnspr4 libxdamage1 libasound2 # add missing dependencies to docker image when convenient
-              image: docker.io/overte/overte-full-build:0.1.1-ubuntu-20.04-amd64
+              # apt-dependencies:  # add missing dependencies to docker image when convenient
+              image: docker.io/overte/overte-full-build:0.1.2-ubuntu-20.04-amd64
             # Android builds are currently failing
             #- os: ubuntu-18.04
             #  build_type: android
@@ -75,7 +75,7 @@ jobs:
               runner: [self_hosted, type-cax41, image-arm-app-docker-ce]
               arch: aarch64
               build_type: full
-              image: docker.io/overte/overte-full-build:0.1.1-ubuntu-22.04-aarch64
+              image: docker.io/overte/overte-full-build:0.1.2-ubuntu-22.04-aarch64
         fail-fast: false
     runs-on: ${{matrix.runner}}
     container: ${{matrix.image}}
@@ -137,9 +137,9 @@ jobs:
           echo "PYTHON_EXEC=python" >> $GITHUB_ENV
           echo "INSTALLER_EXT=exe" >> $GITHUB_ENV
           if [ "${{ matrix.build_type }}" = "full" ]; then
-            echo "CMAKE_EXTRA=-A x64" >> $GITHUB_ENV
+            echo "CMAKE_EXTRA=-A x64 -DJSDOC_ENABLED:BOOL=TRUE" >> $GITHUB_ENV
           else
-            echo "CMAKE_EXTRA=-A x64 -DCLIENT_ONLY=1" >> $GITHUB_ENV
+            echo "CMAKE_EXTRA=-A x64 -DJSDOC_ENABLED:BOOL=TRUE -DCLIENT_ONLY=1" >> $GITHUB_ENV
           fi
         fi
         # Android + Quest build variables
@@ -244,7 +244,7 @@ jobs:
 
     - name: Archive cmake logs
       if: always()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: cmake-logs-${{ matrix.os }}-${{ github.event.number }}.tar.xz
         path: ./cmake-logs-${{ matrix.os }}-${{ github.event.number }}.tar.xz

.github/workflows/release_build.yml

@@ -56,7 +56,6 @@ jobs:
             echo "UPLOAD_PREFIX=build/overte/release/" >> $GITHUB_ENV
         fi
 
-        echo ::set-output name=github_sha_short::`echo $GIT_COMMIT | cut -c1-7`
         echo "JOB_NAME=${{matrix.os}}, ${{matrix.build_type}}" >> $GITHUB_ENV
         echo "APP_TARGET_NAME=$APP_NAME" >> $GITHUB_ENV
 
@@ -101,7 +100,7 @@ jobs:
     - name: Configure CMake
       working-directory: ${{runner.workspace}}/build
       shell: bash
-      run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DVCPKG_BUILD_TYPE=release -DCLIENT_ONLY:BOOLEAN=$CLIENT_ONLY -DBYPASS_SIGNING:BOOLEAN=TRUE $CMAKE_EXTRA
+      run: cmake $GITHUB_WORKSPACE -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DVCPKG_BUILD_TYPE=release -DJSDOC_ENABLED:BOOL=TRUE -DCLIENT_ONLY:BOOLEAN=$CLIENT_ONLY -DBYPASS_SIGNING:BOOLEAN=TRUE $CMAKE_EXTRA
 
     - name: Build application
       working-directory: ${{runner.workspace}}/build

.gitignore

@@ -51,6 +51,7 @@ local.properties
 !.vscode/tasks.json
 !.vscode/launch.json
 !.vscode/extensions.json
+.cache
 # Workspace
 *.code-workspace
 

CHANGELOG.md

@@ -12,9 +12,84 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 This project does **not** adhere to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 
-<!-- ## [2024.09.1] Unreleased -->
+## [2024.11.1] 2024.11.23
 
-## [2024.07.1] 2023.07.12
+### Fixes
+- Hard code link colors in Armored Chat (PR1083)
+- ArmoredChat: Alleviate scrolling issue (PR1106)
+- Armored Chat: Change the 'open in new window' character (PR1084)
+- Fix mouselook ignoring setting. (PR1081)
+- Fix controllerScripts uncaught exception. (PR1086)
+- Fix wireshark dissector (PR1088)
+- Create App: Material Assistant: Add Mtoon, Shader_simple, missing PBR properties and bug fixes. (PR1091)
+- Fix login failure handling and improve logging. (PR1093)
+- add a setting to workaround the GLES colorspace conversion issue (PR1105)
+- Improve model load priority (PR1085)
+- fix accidentally clearing url fields when you don't have view permission (PR1138)
+- Avatar App: Fixed lingering references to now deleted QML element (PR1155)
+- Fix selfie mode movement (PR1127)
+- Fix Create App not honoring menu bar actions (PR1123)
+- Fix Uuid.NULL behavior (PR1168)
+- Rebuild fonts with full charset (NOT -allglyphs) (PR1172)
+- fix web entities not accepting keyboard focus (PR1187)
+- Fix stutter when an object is fading (PR1185)
+- fix density max typo (PR1195)
+- Fix ArmoredChat quick_message qml dialog colors on light theme systems (PR1196)
+- Fix missing properties in Script API (PR1215)
+- Fix ArmoredChat scrolling (PR1210)
+- Force enable JSDoc to get scripting console autocomplete working on Windows (PR1219)
+- Fix lack of entityHostType property (PR1224)
+- Fix access-after-delete on leaving domain with entity scripts (PR1230)
+- fix fade out not working in forward rendering (PR1234)
+- Fix access-after-delete during entity script engine cleanup (PR1236)
+- Fix script-related crashes on exiting a domain (PR1251)
+- Update privacy policy link (PR1237)
+
+### Changes
+- Replace Floofchat with ArmoredChat (PR961)
+- MouseLook.js refactor (PR1004)
+- Custom shader fallbacks (PR1058)
+- Update outdated language (PR1102)
+- Automated entity property serialization (PR1098)
+- Create app: highlight avatar entities (PR1152)
+- Update Avatar App icons (PR1141)
+- Place App: Weekly promoted place (PR1153)
+- Change minimum angular velocity to a lower one (PR1171)
+- Places App: Persisted Maturity Filter and Default value for Newbies. (PR1164)
+
+### Additions
+- Mirrors + Portals (PR721)
+- Entity tags (PR748)
+- Web Entity wantsKeyboardFocus (PR814)
+- Audio Zone Properties (PR847)
+- Ability to smooth model animations (PR889)
+- GPU Particles (PR884)
+- Unlit Shapes (PR1041)
+- Ambient Light Color (PR1043)
+- Dump protocol data (PR1087)
+- Sound Entities (PR894)
+- Zone properties for tonemapping and ambient occlusion (PR1050)
+- Add bloom, haze, AO, and procedural shaders to Graphics settings (PR1053)
+- Create App: Revolutionary "Paste" Url buttons for the "Create Model", "Create Material" and "Create Voxels" UI (PR1094)
+- Text verticalAlignment, send entity property enums as uint8_t, fix text recalculating too often, fix textSize (PR1111)
+- Create app: Grab and Equip (PR1160)
+- Create App: Add "Paste" button for NewSoundDialog QML (PR1202)
+- Added sounds to all incoming chat messages (PR1250)
+
+### Removals
+- Remove (deprecated) attachments (PR1069)
+- Remove unused onFirstRun.js (PR1089)
+- Remove Google Poly (PR1137)
+- Remove hifi screenshare (PR1165)
+
+### Build System
+- Add CLion-style build directories to .gitignore (PR1135)
+
+### Security
+- Sanitize notificationCore text to prevent XSS (PR1078)
+
+
+## [2024.07.1] 2024.07.12
 
 ### Fixes
 - Fix more warnings (PR1007)
@@ -57,7 +132,7 @@ This project does **not** adhere to [Semantic Versioning](https://semver.org/spe
 - Remove remnants of RELEASE_NAME. (PR1077)
 
 
-## [2024.06.1] 2023.06.24
+## [2024.06.1] 2024.06.24
 
 ### Fixes
 - Fix QNetworkRequest::FollowRedirectsAttribute deprecated warning (PR711)
@@ -306,9 +381,6 @@ This project does **not** adhere to [Semantic Versioning](https://semver.org/spe
 - Added a setting to disable snapshot notifications (PR189)
 - Added a setting to switch between screenshot formats (PR134)
 
-### Removals
--
-
 ### Build system
 - Fixed "may be used uninitialized" warning for blendtime (PR269)
 - Updated SPIRV-Cross to sdk-1.3.231.1 (PR271)

assignment-client/src/scripts/EntityScriptServer.cpp

@@ -567,6 +567,7 @@ void EntityScriptServer::addingEntity(const EntityItemID& entityID) {
 
 void EntityScriptServer::deletingEntity(const EntityItemID& entityID) {
     if (_entityViewer.getTree() && !_shuttingDown && _entitiesScriptManager) {
+        // TODO: Check if this is running on script engine thread, otherwise lambda capturing script engine pointer is needed
         _entitiesScriptManager->unloadEntityScript(entityID, true);
     }
 }
@@ -584,6 +585,7 @@ void EntityScriptServer::checkAndCallPreload(const EntityItemID& entityID, bool
         EntityScriptDetails details;
         bool isRunning = _entitiesScriptManager->getEntityScriptDetails(entityID, details);
         if (entity && (forceRedownload || !isRunning || details.scriptText != entity->getServerScripts())) {
+            // TODO: Check if this is running on script engine thread, otherwise lambda capturing script engine pointer is needed
             if (isRunning) {
                 _entitiesScriptManager->unloadEntityScript(entityID, true);
             }

hifi_qt.py

@@ -157,7 +157,7 @@ def __init__(self, args):
                 u_major = int( distro.major_version() or '0' )
                 if distro.id() == 'ubuntu' or distro.id() == 'linuxmint':
                     if (distro.id() == 'ubuntu' and u_major == 20) or distro.id() == 'linuxmint' and u_major == 20:
-                        self.qtUrl = self.assets_url + '/dependencies/qt5/qt5-install-5.15.14-2024.06.17-kde_570f5b2105df1ea052bec0d6dbf8a00137274371-ubuntu-20.04-amd64.tar.xz'
+                        self.qtUrl = self.assets_url + '/dependencies/qt5/qt5-install-5.15.16-2024.12.14-kde_32be154325bfba3ad2ba8bf75dad702f3588e8d3-ubuntu-20.04-amd64.tar.xz'
                     elif (distro.id() == 'ubuntu' and u_major > 20) or (distro.id() == 'linuxmint' and u_major > 20):
                         self.__no_qt_package_error()
                     else: