Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplified svgs and fixed them #468

Merged
merged 8 commits into from
May 24, 2024
Merged

simplified svgs and fixed them #468

merged 8 commits into from
May 24, 2024

Conversation

ermish
Copy link
Contributor

@ermish ermish commented May 15, 2024 •
edited

Resolves #441
Resolves #417

🔧 What changed

  • Simplified our svgs. Removed the <symbol> tags. Now they only need an id attribute on the <svg id> tag to work properly.
  • Fixed some <img> to use <svg> to be consistent
  • fixed the about page heart svg bug
  • Fixed the marker deprecation warning for google maps. I switched it to a custom marker which was a little simpler (surprisingly) and was easier to work with for svgs.
  • Breaking change: moved the svg icons to a new /assets/icons folder so they can be optimized more easily and our jpg/png images can be optimized separately.

🧪 Testing instructions

  • make sure svgs show up

📸 Screenshots

  • Before

image

  • After

image

@ermish ermish self-assigned this May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited

✅ Deploy Preview for findadoc ready!

Name Link
🔨 Latest commit 3ce7e6c
🔍 Latest deploy log https://app.netlify.com/sites/findadoc/deploys/66506927cb08e6000875eb2c
😎 Deploy Preview https://deploy-preview-468--findadoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@socket-security Socket Security
Copy link

socket-security bot commented May 20, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@istanbuljs/[email protected] None 0 17.2 kB coreyfarrell
npm/@types/[email protected] None 0 5.45 kB types
npm/[email protected] None 0 52.4 kB marijn
npm/[email protected] None 0 6.69 kB sindresorhus
npm/[email protected] None 0 8.05 kB iarna
npm/[email protected] None 0 11.7 kB sindresorhus
npm/[email protected] filesystem 0 5.75 kB isaacs
npm/[email protected] None 0 5.51 kB sindresorhus
npm/[email protected] None 0 9.23 kB isaacs
npm/[email protected] None 0 12.7 kB iarna
npm/[email protected] filesystem, unsafe 0 6.25 kB pi0
npm/[email protected] None 0 7.46 kB tjholowaychuk
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] filesystem 0 11.6 kB lukeed
npm/[email protected] None 0 26.6 kB timoxley
npm/[email protected] None 0 8.68 kB keithamus
npm/[email protected] environment 0 3.44 kB iarna
npm/[email protected] None 0 124 kB mathias
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] None 0 4.4 kB sindresorhus
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] None 0 9.62 kB jonschlinkert
npm/[email protected] environment, filesystem 0 19.1 kB isaacs
npm/[email protected] None 0 27.4 kB dougwilson
npm/[email protected] None 0 23.9 kB cpsoinos
npm/[email protected] None 0 4.51 kB jbgutierrez
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 15.6 kB achingbrain
npm/[email protected] None 0 6.36 kB cwmma
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] network 0 156 kB joshglazebrook
npm/[email protected] None 0 9.18 kB ljharb
npm/[email protected] None 0 174 kB dchest
npm/[email protected] None 0 73.1 kB ethan_arrowood
npm/[email protected] None 0 5.48 kB tootallnate
npm/[email protected] None 0 231 kB husamibrahim
npm/[email protected] None 0 4.47 kB iarna
npm/[email protected] None 0 6.03 kB sindresorhus

🚮 Removed packages: npm/@antfu/[email protected], npm/@nuxt/[email protected], npm/@nuxt/[email protected], npm/@unhead/[email protected], npm/@unhead/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/@vue/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@ermish ermish marked this pull request as ready for review May 21, 2024 03:33
@ermish ermish closed this May 21, 2024
@ermish ermish reopened this May 21, 2024
@ermish ermish mentioned this pull request May 21, 2024
Closed
1 task
@theyokohamalife theyokohamalife self-requested a review May 24, 2024 10:06
theyokohamalife
theyokohamalife approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@theyokohamalife theyokohamalife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@theyokohamalife theyokohamalife merged commit 89f7f43 into main May 24, 2024
9 checks passed
@theyokohamalife theyokohamalife deleted the ermish/svgs branch May 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theyokohamalife theyokohamalife theyokohamalife approved these changes

Assignees

@ermish ermish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Icons not rendering on prod [bug] update google maps marker
2 participants
@ermish @theyokohamalife