[bug] Icons not rendering on prod

[theyokohamalife]

Icons are currently not rendering on prod for the site logo, healthcare professionals, and languages.

[theyokohamalife]

We'll tackle this on Wednesday in a group coding session.

[NabbeunNabi]

I was wondering @ermish and @theyokohamalife if you have looked at this and think it is a good add to the project, vue-svg-loader?

Pros

1. Imports SVG as components so looks clean in the code.
2. Has very few dependencies. Only 2

Cons

1. Has dependencies so it does add more to the project

[ermish]

I was wondering @ermish and @theyokohamalife if you have looked at this and think it is a good add to the project, vue-svg-loader?

Pros

1. Imports SVG as components so looks clean in the code.
2. Has very few dependencies. Only 2

Cons

1. Has dependencies so it does add more to the project

a best practice is to have all images (including svg's) to be cacheable which means they should not be inlined. Unfortunately vue-svg-loader inlines them, so it's not a valid option

[NabbeunNabi]

But as mentioned yesterday it seems like the way we did it on the about us page fits the requirements for svgs and makes it cacheable so we should proceed that way?

[ermish]

But as mentioned yesterday it seems like the way we did it on the about us page fits the requirements for svgs and makes it cacheable so we should proceed that way?

yeah, that should be fine. Just documenting the thoughts for anyone else reading this. 👍

[ermish]

I'll have a PR ready for this soon 🔥