Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page - search bar full styling support #147

Open
8 tasks
ermish opened this issue Jan 4, 2023 · 3 comments
Open
8 tasks

Search page - search bar full styling support #147

ermish opened this issue Jan 4, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ermish
Copy link
Contributor

ermish commented Jan 4, 2023

Requirements

  • Finish up styling the search bar
    • change karat color to primary
    • fix font size and coloring
    • fix placeholders
  • research using vue-select vs using native <select> element
    • Look into safari styling not applying
    • is it worth the overhead?
    • does it support multi-select?

Dependencies

  • None (Add any issue dependencies here)
@ermish ermish added the enhancement New feature or request label Jan 4, 2023
@ermish ermish self-assigned this Jan 4, 2023
@ann-kilzer ann-kilzer added this to the Milestone 3: March 🎎 milestone Mar 2, 2023
@ermish ermish assigned NabbeunNabi and unassigned ermish Mar 18, 2024
@NabbeunNabi
Copy link
Contributor

I have some questions about the ticket I was assigned. There are a lot of designs on figma so I do not know exactly which one I am supposed to follow for the TopNav/SearchBar part. Which should I follow?

@NabbeunNabi
Copy link
Contributor

NabbeunNabi commented Apr 8, 2024

<select> Choices

Make our own

  • Pros
  1. Can be customizable to exactly what we want
  2. Possibly might not have trouble to adapt to our data
  3. More control over performance cost
  • Cons
  1. Time consuming
  2. Needs a lot of testing due to not being used by thousands of other developers

Use Vue Multi-Select

Link to Vue Multi-Select Page

  • Pros
  1. Tested and proven to work
  2. Easy to add to our project
  3. Solid documentation
  • Cons
  1. Might be tricky to adapt to our search query depending how we are handling it now
  2. Could have extra performance costs that we cannot control
  3. Not clear on whether it includes CSS

Use vue-select

Link to vue-select Page

  • Pros
  1. Tested and proven to work
  2. Just like multi-select it has great documentation
  3. Self-reported to be lightweight
  4. Does not include any CSS so that way we do not have to worry about conflicts with our CSS in tailwind
  • Cons
  1. Might have to change how we handle the query

My Research and Thoughts

Through my research I think it will be better to use the built in vue-select component. For an open source project it will be easier for developers who come in and out of the project to read the documentation and adjust the files when needed. I do not think that it will be too much if any extra performance cost. It also handles typing search and multi-select which is wonderful for a built in component. It will also be better than the multi-select built in component as we do not have to worry about any styling from the CSS as there is no built in CSS.

Styling mismatch on Safari and Chrome (Firefox doesn't always accept webkit)

  • The select itself needs to use webkit to get rid of the default styling so it then takes our styling based on my research. So we need to change the original CSS file. See MDN here
  • I think this is worth it for the scroll bar like I was talking about before as they appear differently as well as the select field to make the styling consistent across browsers.

@ermish
Copy link
Contributor Author

ermish commented Apr 8, 2024

this looks great! let's try out vue-select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants