-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic observed when a node gets deleted #9
Comments
I'm seeing this quite frequently also, is there a good |
Fixes issue reported in #9 regarding object not being a Node object. Removed DeleteFunc callback as it is not needed.
@blakebarnett I'm still trying to find some time out of my schedule to rewrite this controller, which will include health checks and metrics (ie. sync duration). For now, I created a quick patch that should solve the immediate problem with these panics: I'm not going to be able to test this until early next week; can you give this patch a try and see if this will alleviate your issues? |
@blakebarnett Forgot to link the built image: The docker image is, for that branch is: |
I'll do some testing with it, thanks! |
Have you approached the calico team about adding this to calico-kube-controllers? It would solve the problem of not being able to do a conditional deploy on upgrades via kops also... |
My testing looks good btw... |
@blakebarnett I merged the patch; going to roll a release. I have not approached the calico team about this but it sounds like a good idea perhaps to put this logic in kube-controllers if they're ok with the idea of having cloud specific implementation details. |
great timing! I'm upgrading our prod cluster tonight. |
guess this needs to be upstreamed - https://sourcegraph.com/github.com/kubernetes/[email protected]/-/blob/upup/models/cloudup/resources/addons/networking.projectcalico.org/k8s-1.7.yaml.template#L515:47 I'll open a PR if nobody else (but it's going to take me few days to get around to that) |
A panic occurs when a node gets deleted and returns a cache.DeletedFinalStateUnknown instead of a Node.
a rewrite is in-order with the new style of writing these Controllers in client-go...
Related to: kubernetes/kops#4466
The text was updated successfully, but these errors were encountered: