Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Club page emails are hardcoded to mailto: links #285

Open
ct-martin opened this issue Apr 6, 2019 · 3 comments
Open

Club page emails are hardcoded to mailto: links #285

ct-martin opened this issue Apr 6, 2019 · 3 comments

Comments

@ct-martin
Copy link

Club emails are hard-coded to mailto: links regardless whether they are links or emails, e.g. RITlug's mailing list gets converted to mailto:https://groups.google.com/forum/#!forum/ritlug-announce

See:

/**
* EmailInfo wrapper.
* Constructs email element.
*
* @param {String} email The club email
*/
const EmailInfo = ({ email }) => (
<li className="club-info__item-wrapper">
<ClubInfoItem email={`mailto:${email}`}>
<Email value={email} />
</ClubInfoItem>
</li>
);

@shakti97
Copy link
Contributor

shakti97 commented Oct 3, 2019

Can you explain a little bit more?
Are trying to say that the email prop will have to types of content either email or links
For email we need mailto but for links we don't
is this you want to say?

@ct-martin
Copy link
Author

@shakti97 RITlug uses a mailing list rather than a set email, which there's a link to and that link should not get cast to mailto:. If you look at the example in the OP, the RITlug mailing list has two protocols given. Granted, I wrote this issue 6 months ago so I'm doing this based on what I see in the OP.

@ct-martin
Copy link
Author

(so I guess this is a feature request to support links as a data type in addition to email addresses?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants