Invalid path in mkdirs.sh

[ksiddi01]

pg_rman restore is failing due to incomplete path in mkdirs.sh file.

Invalid paths:
mkdir -m 700 -p ts
mkdir -m 700 -p ts/PG_10_201707211
mkdir -m 700 -p ts/PG_10_201707211/16395
mkdir -m 700 -p ts/PG_11_201809051
mkdir -m 700 -p ts/PG_11_201809051/16402

Corrected paths:
mkdir -m 700 -p /pgsql/data/ilmrep1p_ts
mkdir -m 700 -p /pgsql/data/ilmrep1p_ts/PG_10_201707211
mkdir -m 700 -p /pgsql/data/ilmrep1p_ts/PG_10_201707211/16395
mkdir -m 700 -p /pgsql/data/ilmrep1p_ts/PG_11_201809051
mkdir -m 700 -p /pgsql/data/ilmrep1p_ts/PG_11_201809051/16402

After mkdirs.sh is modified, restore works properly. Is it because of "_" in folder name (ilmrep1p_ts) ?

mkdirs.sh.txt

[MoonInsung]

Dear @ksiddi01

Could you share the method of reproduction?
It seems that the issue is not related to the file name.

Best regards.
Moon.

[mikecaat]

Hi,

We could reproduce the above situation.

The root cause seems to be that the logic to check whether the tablespace or $PGDATA is wrong.
The problem occurs if the prefix of tablespace path has $PGDATA path.

@ksiddi01
I assume that the conditions of your environments are like the following, right?

• $PGDATA: /pgsql/data/ilmrep1p
• tablespace path: /pgsql/data/ilmrep1p_ts

The following is the reproduction way.

# reproduced environments
> pg_rman --version
pg_rman 1.3.13

> psql -c "SELECT version();" 
                                               version
------------------------------------------------------------------------------------------------------
 PostgreSQL 14.0 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0, 64-bit
(1 row)

# create PostgreSQL server
> vim tmp_env
export BACKUP_PATH=/tmp/pg_rman_catalog
export PGDATA=/tmp/pgdata
> source tmp_env
> initdb;
> echo "archive_mode = on 
archive_command = 'cp %p /tmp/data.arch/%f'                                                                                                                                                 
restore_command = 'cp /tmp/data.arch/%f %p'                                                                                                                                                 
" >> ${PGDATA}/postgresql.conf
> mkdir /tmp/data.arch
> pg_ctl start

# create table space
> vim create_tablespace.sql
-- the prefix of the location directory is the *same* of PGDATA=/tmp/pgdata
CREATE TABLESPACE tblspc LOCATION '/tmp/pgdata_tblspc';
CREATE DATABASE test_db TABLESPACE tblspc;
> mkdir /tmp/pgdata_tblspc      # the path is "${PGDATA}_tblspc"
> psql -f create_tablespace.sql

> pg_rman init; pg_rman backup -b full; pg_rman validate 
> pg_ctl stop
> pg_rman restore
ERROR: could not open restore target file "/tmp/pgdata/pg_tblspc/16384/PG_14_202107181/16385/112": そのようなファイルやディレクトリはありません

> cat ${BACKUP_PATH}/*/*/mkdirs.sh
mkdir -m 700 -p base
mkdir -m 700 -p base/1
mkdir -m 700 -p base/13009
mkdir -m 700 -p base/13010
mkdir -m 700 -p global
mkdir -m 700 -p pg_commit_ts
mkdir -m 700 -p pg_dynshmem
mkdir -m 700 -p pg_logical
mkdir -m 700 -p pg_logical/mappings
mkdir -m 700 -p pg_logical/snapshots
mkdir -m 700 -p pg_multixact
mkdir -m 700 -p pg_multixact/members
mkdir -m 700 -p pg_multixact/offsets
mkdir -m 700 -p pg_notify
mkdir -m 700 -p pg_replslot
mkdir -m 700 -p pg_serial
mkdir -m 700 -p pg_snapshots
mkdir -m 700 -p pg_stat
mkdir -m 700 -p pg_stat_tmp
mkdir -m 700 -p pg_subtrans
mkdir -m 700 -p pg_tblspc
mkdir -m 700 -p pg_twophase
mkdir -m 700 -p pg_wal
mkdir -m 700 -p pg_wal/archive_status
mkdir -m 700 -p pg_xact
mkdir -m 700 -p tblspc
mkdir -m 700 -p tblspc/PG_14_202107181
mkdir -m 700 -p tblspc/PG_14_202107181/16385

rm -f pg_tblspc/16384
ln -s /tmp/pgdata_tblspc pg_tblspc/16384

Regards,

[huangfumingyue]

Thanks.
It looks good for me