Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom images #62

Open
ospalh opened this issue Mar 12, 2015 · 8 comments
Open

Zoom images #62

ospalh opened this issue Mar 12, 2015 · 8 comments

Comments

@ospalh
Copy link
Owner

ospalh commented Mar 12, 2015

Make zoom.py zoom the images as well.

@ospalh
Copy link
Owner Author

ospalh commented Sep 21, 2015

It is rather simple to use setZoomFactor() instead of setTextSizeMultiplier(), but dealing with the max size is a bit more trick, especially when the user has changed it in the styling.

@jameskraus
Copy link

@ospalh

https://gist.github.com/jameskraus/d459fc504e572c3997f7

What's the issue with max size?

@ospalh
Copy link
Owner Author

ospalh commented Feb 21, 2016

What's the deal with pushing one file to gist without any history, instead of pushing a commit to github?
I cba to look if you did any changes to that file.

@jameskraus
Copy link

Eh, I was honestly too lazy to check out the repo and commit the changes (I only use Zoom.py).

Only change is replacing setTextSizeMultiplier() with setZoomFactor() + the associated get methods.

And what's the issue with max size?

@ospalh
Copy link
Owner Author

ospalh commented Feb 22, 2016

What happens when the user has max-width or similar in their CSS?
What should happen then?

@jameskraus
Copy link

Just a guess: If max-width is set to an absolute value, that value probably scales along with the zoom. If it's set to a relative value, the constrained dimension probably doesn't scale with the zoom. Edit: Either way, the rendering engine should take care of it.

@ospalh
Copy link
Owner Author

ospalh commented Feb 23, 2016

You seem much more interested in this one add-on than i am.
If you want, you may take over development. (Maybe start a new repo, or clone this one, remove all files but this and rename it.)

@krassowski
Copy link
Contributor

@ospalh I created a pull request which resolves several issues with zoom add-on for Anki 2.1. It also uses setZoomFactor as setTextSizeMultiplier is not available in PyQT5. If you do not have time to review and publish it please let me know and I will take care of it. Nonetheless, it should be an easy task now after the code has been written and committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants