Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Suggestions] Invalid Tag Check #391

Open
ylinzhi opened this issue Oct 19, 2020 · 1 comment
Open

[Fix Suggestions] Invalid Tag Check #391

ylinzhi opened this issue Oct 19, 2020 · 1 comment

Comments

@ylinzhi
Copy link
Contributor

ylinzhi commented Oct 19, 2020

Which Atlas check is the fix suggestion related to?

Invalid Tag Check
Description: https://github.com/osmlab/atlas-checks/blob/ca315302ff16b1743593a5d4b4aa71c4b4e57b02/docs/checks/invalidTagsCheck.md

Script: https://github.com/osmlab/atlas-checks/blob/ca315302ff16b1743593a5d4b4aa71c4b4e57b02/src/test/java/org/openstreetmap/atlas/checks/validation/tag/InvalidTagsCheckTest.java

Describe more details of suggested fix(es)

Suggested Fix 1: Invalid Area Tag in Roundabout

  • Type of fixing: Tag fix

  • Operation: Delete

  • Suggested Action: Remove "area=*" tag on roundabout

Is there any code enhancement needed if adding the fix suggestion component?

No

@ylinzhi ylinzhi changed the title [Fix Suggestions] [Fix Suggestions] Invalid Tag Check Oct 19, 2020
@sayas01
Copy link
Collaborator

sayas01 commented Nov 3, 2020

The current logic of InvalidTagsCheck uses taggable filters passed through a config / resource file to flag atlas objects that have invalid tags. Adding autofix suggestions to InvalidTagsCheck will require code change. One solution would be to pass the action(DELETE) and tag in the resource/ config along with the taggable filter and instruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants