Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $wgLogo instead of hard-coding #23

Open
samwilson opened this issue Jul 10, 2018 · 4 comments
Open

Use $wgLogo instead of hard-coding #23

samwilson opened this issue Jul 10, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@samwilson
Copy link

The logo path is currently being hard-coded to skins/OSMFoundation/img/logo.png, this should instead use the $wgLogo configuration variable. Then this skin would be more usable by more sites (e.g. https://phabricator.miraheze.org/T3337 ).

@nebulon42
Copy link
Contributor

Thanks for raising this issue here. Thing is that this theme is not really meant to be reused by others hence I did not pay attention to make it reusable. The theme is public because at OSM we value openness highly. I'm not categorically against it being reused, but I'm not sure I'd like to put effort into supporting other use cases. I will consult with others on what our stance on reusing this theme is and report back here.

@nebulon42 nebulon42 added the enhancement New feature or request label Jul 10, 2018
@samwilson
Copy link
Author

Thanks @nebulon42 that makes sense.

@jdlrobson
Copy link
Contributor

This should be fixed now.

@samwilson
Copy link
Author

Great!

The logo is still in the repo, and mentioned in README.md, so probably this is still not quite ready for re-use elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants