Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional protoc parameters #98

Open
stephanpelikan opened this issue Dec 29, 2020 · 4 comments
Open

Support additional protoc parameters #98

stephanpelikan opened this issue Dec 29, 2020 · 4 comments

Comments

@stephanpelikan
Copy link

I want to use the "optional" attribute which is an experimental feature (https://github.com/protocolbuffers/protobuf/blob/master/docs/field_presence.md) and has to be enabled using the protoc parameter "--experimental_allow_proto3_optional".

As far as I could figure out, there is no way to add additional protoc parameters using this Maven plugin. Something like

<configuration>
  <additionalParameters>--experimental_allow_proto3_optional</additionalParameters>
</configuration>

would be great. Could you please add this feature!?

@os72
Copy link
Owner

os72 commented Jan 6, 2021

Are you using the project professionally? I'm trying to garner some support (sponsorship) for it..

@stephanpelikan
Copy link
Author

We're evaluating Apache Flink which recommends using protobuf. As we're using Maven I found your plugin useful. Anyway, if we start to rely on it I could ask my supervisor. Until then I also can provide a pull request to support your project.

@nwbirnie
Copy link

nwbirnie commented Feb 10, 2021

I just ran into this as well.

The latest protoc RC (3.15.0-rc1) supports proto3 optional without requiring the command line flag.

@JHahnHRO
Copy link

Nevertheless would it be very useful to have a way to specify additional command line parameters for the protoc invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants