Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build on Apple M1 - protocolbuffer #129

Open
ravileeladhar2023 opened this issue Oct 4, 2022 · 5 comments
Open

Cannot build on Apple M1 - protocolbuffer #129

ravileeladhar2023 opened this issue Oct 4, 2022 · 5 comments

Comments

@ravileeladhar2023
Copy link

Hi

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 0.630 s
[INFO] Finished at: 2022-10-04T15:10:04+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (generate-sources) on project fcpsinboundadapter: Error extracting protoc for version 3.11.4: Unsupported platform: protoc-3.11.4-osx-aarch_64.exe -> [Help 1]

o Reproduce

On a macOS machine with properties:

MacBook Pro (16-inch, 2021)
Chip Apple M1 Pro

@ennerf
Copy link

ennerf commented Jan 5, 2023

Google started releasing the osx aarch64 version in 3.17.3.

For older versions like 3.11.4 you'd have to fall back to the x86_64 version using mvn <command> -Dos.arch=x64_64.

You can specify the version in the configuration

<configuration>
    <protocVersion>${protoc.version}</protocVersion>
</configuration>

andozw added a commit to square/subzero that referenced this issue Mar 3, 2023
And update to the latest version. Apple started releasing the osx
aarch64 (M1) version in 3.17.3
[link](os72/protoc-jar-maven-plugin#129)

This is a fix for this error on M1 builds:
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project proto:
Error extracting protoc for version 3.11.4: Unsupported platform: protoc-3.11.4-osx-aarch_64.exe -> [Help 1]
andozw added a commit to square/subzero that referenced this issue Mar 6, 2023
And update to the latest version. Apple started releasing the osx
aarch64 (M1) version in 3.17.3
[link](os72/protoc-jar-maven-plugin#129)

This is a fix for this error on M1 builds:
[ERROR] Failed to execute goal com.github.os72:protoc-jar-maven-plugin:3.11.4:run (default) on project proto:
Error extracting protoc for version 3.11.4: Unsupported platform: protoc-3.11.4-osx-aarch_64.exe -> [Help 1]
@spensonshih
Copy link

@ravileeladhar2023, I encountered the same. Please checkout the fork: https://github.com/blackrock/protoc-jar-maven-plugin

This forked version uses Google’s Protoc version 3.25.1 by default which supports osx aarch64.

@ennerf
Copy link

ennerf commented May 3, 2024

@spensonshih Looking at your repo it looks like you (1) forked the project without the commit history, (2) changed all namespaces, (3) added BlackRock logos, and (4) removed all links to the original repo.

It looks like most of the code is straight up copied, but anyone looking at the repo will get the impression that you're the original authors. That is not cool.

@spensonshih
Copy link

@ennerf we considered this project as abandoned, and by taking over maintenance of the project, we had to put the repo under BlackRock namespace in order to publish to Maven Central.

Our README has clearly included credit to the original repo.

IMG_0777

You’ll also notice this repo was original from another repo: https://github.com/igor-petruk/protobuf-maven-plugin

IMG_0779

@ennerf
Copy link

ennerf commented May 3, 2024

edit: somehow I missed the link. It could be more obvious, but good luck 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants