You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@pankaj Agrawal i think we should obsolete that functionality (for now) or restrict it so that we send to groups < 32 contacts only (or some small number). We should encourage people to use start contact on flows instead
we need to rewrite that code to use a mechanism like broadcast. it currently loops forever sending each contact one at a time (with no upper limit)
and I suspect the front end is waiting and then repeats the call since the first call has not returned. @mohd Shamoon or @kurund can confirm behaviour on this and/or apollo in case of timeout
I recommend we put in a hotfix to disable this if the group size is too big for now
(so change backend only)
we can discuss tomorrow and see what it takes to move @tejas-reapbenefit to use start flow for a group scheme
so here's my suggestion:
hotfix backend to not disable functionality for groups > 32 contacts
Extend broadcast table to handle 3 cases: start the flow, send session message, send hsm message. Here we'll need to store the message_params and the message type
Extend the broadcast_contacts code to handle the latter two cases
I looked at the code and it seems quite feasible, but I think we should sleep over items 2 and 3 and roll 1 into production soon
This discussion was converted from issue #2240 on June 16, 2022 15:02.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
From @dlobo
@pankaj Agrawal i think we should obsolete that functionality (for now) or restrict it so that we send to groups < 32 contacts only (or some small number). We should encourage people to use start contact on flows instead
we need to rewrite that code to use a mechanism like broadcast. it currently loops forever sending each contact one at a time (with no upper limit)
and I suspect the front end is waiting and then repeats the call since the first call has not returned. @mohd Shamoon or @kurund can confirm behaviour on this and/or apollo in case of timeout
I recommend we put in a hotfix to disable this if the group size is too big for now
(so change backend only)
we can discuss tomorrow and see what it takes to move @tejas-reapbenefit to use start flow for a group scheme
so here's my suggestion:
I looked at the code and it seems quite feasible, but I think we should sleep over items 2 and 3 and roll 1 into production soon
Beta Was this translation helpful? Give feedback.
All reactions