GitHub Community
Allow changing PR author #15067
Replies: 50 comments 1 reply
-
|
+1 for this. I created a draft PR for a proof-of-concept a while back, and today one of my teammates finished the job. He put in much more work than I did, and then published the PR, and I can't approve it. There are a bunch of questions on stackoverflow about this kind of thing. The workaround is to open a new PR, but then you lose any comments and approvals from the original PR. https://stackoverflow.com/questions/50781553/how-to-take-ownership-of-a-pull-request |
Beta Was this translation helpful? Give feedback.
-
|
+1 I reverted a change, I restored the branch, and I made a new PR to make my developer's life easier, but now he's going to write the fix and I'm supposed to review it and can't because I own it. It would be nice if I could edit the PR author field. I understand how this could be abused to allow me to review my own PRs, but assuming the second developer has to accept the invitation to be the new author this could be avoided. |
Beta Was this translation helpful? Give feedback.
-
|
+1 I started with a minor change made by a teammate but it became clear that much more work was required to actually deliver on the goal. The original teammate left for vacation and handed that work off to me. After completing my changes I discovered that I had the power to review and merge it myself (I didn't do it) even though almost 100% of the code was mine. I shouldn't have that ability. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this can we expect this feature anytime in the near future? |
Beta Was this translation helpful? Give feedback.
-
|
Our team would also find this very useful. |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this. I think this is useful because we could have someone drop a pull request for some reason and needing someone to continue doing it, without losing comments or reviews. And also not allowing, as a consequence, the new author to approve it's own PR (since in the current version it's technically not theirs) |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this. Handed off a project to a co-worker, and now I can't review the PR because I still own it. |
Beta Was this translation helpful? Give feedback.
-
|
+1. Phab-style commandeering would be very helpful! |
Beta Was this translation helpful? Give feedback.
-
|
+1 |
Beta Was this translation helpful? Give feedback.
-
|
I think this is useful because we could have someone drop a pull request for some reason and needing someone to continue doing it, without losing comments or reviews. And also not allowing, as a consequence, the new author to approve it's own PR (since in the current version it's technically not theirs) |
Beta Was this translation helpful? Give feedback.
-
|
+1 I ended up searching if this functionality exists for the exact same reasons stated by everyone above, would be good to see if this can be implemented. |
Beta Was this translation helpful? Give feedback.
-
|
Or just allowing the creator to request changes to the pr in general |
Beta Was this translation helpful? Give feedback.
and others
-
Much like changing the PR title, description, reviewers or assignee, it is sometimes useful to be able to change the author/owner of the PR.
One common scenario I tend to encounter is a PR being opened by some user, then the ownership of that feature is passed to another users which continues the first user's work. This is of course already possible, but if the new owner now wants to set the former owner as reviewer, or the former owners want to request changes from the new owner, they currently can't do that.
Another less common scenario is when a PR is automatically created by some faceless user, then a real human user wants to take ownership of that PR to continue and finish up the work.
Beta Was this translation helpful? Give feedback.
All reactions