You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi there, I'm from the Python organization here on GitHub.
Recently, we had to switch back to "Require approvals for first-time contributors" (from the previously used "... who are new to GitHub" due to CI spam:
When we did that, one of our GitHub apps, "bedevere", started triggering workflow approvals as if the bot was "a new contributor":
However, in the above screenshot you can see how the workflow approval only happens for the "unlabeled" trigger.
More screenshots
The "unlabeled" trigger causes an "Approve and run" button to appear on the PR.
The "labeled" trigger does not cause this and the check runs fine.
The workflow file lists both triggers in the same list, there should be no difference between them.
Expected behavior
Bots should not be treated as "new contributors", and therefore should never trigger "Approve and run". And even if they did, all triggers should behave the same. And if we approve the run and land a PR, that bot should no longer be treated as a "new contributor".
This is somewhat disruptive to Python as the bots are our automation that acts on every single PR. We would rather not have to switch back to "... who are new to GitHub" due to CI spam issues while we are already backed up on CI resources.
BugSomething isn't working correctlyActionsBuild, test, and automate your deployment pipeline with world-class CI/CDProduct Feedback
1 participant
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Select Topic Area
Bug
Body
Hi there, I'm from the Python organization here on GitHub.
Recently, we had to switch back to "Require approvals for first-time contributors" (from the previously used "... who are new to GitHub" due to CI spam:
When we did that, one of our GitHub apps, "bedevere", started triggering workflow approvals as if the bot was "a new contributor":
However, in the above screenshot you can see how the workflow approval only happens for the "unlabeled" trigger.
More screenshots
The "unlabeled" trigger causes an "Approve and run" button to appear on the PR.The "labeled" trigger does not cause this and the check runs fine.
The workflow file lists both triggers in the same list, there should be no difference between them.
Expected behavior
Bots should not be treated as "new contributors", and therefore should never trigger "Approve and run". And even if they did, all triggers should behave the same. And if we approve the run and land a PR, that bot should no longer be treated as a "new contributor".
This is somewhat disruptive to Python as the bots are our automation that acts on every single PR. We would rather not have to switch back to "... who are new to GitHub" due to CI spam issues while we are already backed up on CI resources.
Please advise 😇
Beta Was this translation helpful? Give feedback.
All reactions