Rust Octocrab API Reliably Stops Returning Pages

[Pspritechologist]

Select Topic Area

Question

Body

I'm writing an app to mirror PRs from repo A into repo B. To do so, the bot needs to collect all PRs made to repo A. I've written it using the Rust crate Octocrab, which has been working fine for the most part.
The issue I'm running into is during the loop where I'm collecting each page (using the 'next page' link provided in the response), at a certain point the function call just hangs and doesn't respond at all. This is reliably at page 56-59, although not a consistent single page.

I've confirmed this issue occurs over multiple repositories, one of which being the microsoft/winget-pkgs repo.
Below is the code I'm using to do this, albeit simplified due to lack of context.

    let mut page = match octocrab.pulls(&config.clone_repo.owner, &config.clone_repo.name)
        .list()
        .sort(Sort::Created)
        .direction(Direction::Descending)
        .base(&config.clone_repo.branch)
        .state(params::State::Closed)
        .per_page(100)
        .send().await {
            Ok(p) => p,
            Err(err) => // Catches error
            }
        };

    // Start our collection.
    let mut all_prs = page.take_items();

    let mut i = 1;
    while page.next.is_some() {
        page = match octocrab.get_page(&page.next.clone()).await {
            Ok(p) => p.unwrap_or_else( // Catches error)
            Err(err) => // Catches error
        };

        all_prs.extend(page.take_items());
        i += 1;

        print!("Done with page #{}, PR #{}...\r", i, all_prs.last().unwrap().number);
        let _ = std::io::stdout().flush();
    }

It hangs on the octocrab.get_page line, after page number 56-59 as said before. I am absolutely stumped on what could be the cause.
The issue is not solved either by including a 30 second wait after obtaining 50 pages, nor by including a few second long wait between each page. Starting from page 50 did not stop at the same page.

I'm pretty new to using APIs like this in general, and completely new to the GitHub one. I'm also rather new to Rust :P
Any help is greatly appreciated.

(For context, this originally contained a shell script that I thought displayed similar issues, but it seemed I was making an unrelated mistake there. I've instead left the Rust code that is causing me issues.)

[ThisaraJayas]

GITHUB_TOKEN=
REPO_OWNER=
REPO_NAME=

page=1

while true; do
response=$(curl -s -H "Authorization: token ${GITHUB_TOKEN}"
"https://api.github.com/repos/$REPO_OWNER/$REPO_NAME/pulls?page=$page&per_page=100&state=closed&sort=created&direction=desc")

if [ -z "$response" ]; then
echo "No more pull requests found."
break
fi

Output the response

echo "$response"

echo "Done with page #$page"

((page++))
done

[Pspritechologist]

It seems that a pair of missing quotes around the URL fixes that issue, my mistake there. I'll update the title to reflect that this is just about my experience in Rust, then.