pppoe: Can not load module without loading radius module

[Tokarak]

Running branch master on Entware with #188 merged. If pppoe module is loaded before radius module (which is always the case if using chap_secrets for authentication, as it conflicts with radius), accel-ppp will refuse to launch with this error: [2024-09-04 14:40:13.626]loader: failed to load 'pppoe': /opt/lib/accel-ppp/libpppoe.so: undefined symbol: rad_packet_add_int.
I think this issue is similar to #131, and the fix might be a similar one-liner.
Bug also present in 1.12.0 on Entware, as I commented in #131

[svlobanov]

It was fixed in 3be221b . Please check modules order in your configuration

[Tokarak]

[modules]
log_file
log_syslog
#log_tcp
#log_pgsql

connlimit

#radius
chap-secrets

#pptp
#l2tp
#sstp
pppoe
#ipoe

auth_mschap_v2
auth_mschap_v1
auth_chap_md5
auth_pap

ippool
...

I don't see anything wrong? In 3be221b, radius is always loaded before pppoe in all the tests.

[svlobanov]

Just uncomment radius module

[Tokarak]

Are you saying that the following is outdated?

Currently accel-ppp may works only with one of the authentication method, chap-secrets or RADIUS. RADIUS has more priority if set in [modules] section. Remove or #comment radius from section [modules] if you want use chap-secrets. Example:
...

— https://docs.accel-ppp.org/configuration/chap_secrets.html

edit: I'm testing with radius mod loaded, and not getting any errors; I'm not sure if I'm using chap secrets as authentication.

[Tokarak]

Currently accel-ppp may works only with one of the authentication method, chap-secrets or RADIUS. RADIUS has more priority if set in [modules] section. Remove or #comment radius from section [modules] if you want use chap-secrets. Example:

This is NOT outdated. My logs are showing that radius is used for authentication, not chap-secrets, on my PPPoE server. This issue is still open.

[Tokarak]

Linking to radius unconditionally causes the build to fail when -DRADIUS=FALSE is set. Probably a good thing, it's better to fix the underlying issue.

[Tokarak]

accel-ppp/accel-pppd/ctrl/pppoe/CMakeLists.txt

Lines 3 to 13 in 0c021f6

	SET(sources
	pppoe.c
	mac_filter.c
	dpado.c
	cli.c
	disc.c
	)
	IF (RADIUS)
	SET(sources ${sources} tr101.c)
	ENDIF(RADIUS)

The solution is to just link conditionally, just like this file.

[svlobanov]

Can you change your PR to be able to build without radius? (Link conditionally)

[svlobanov]

Thanks for your contribution. I will try to add a test for pppoe+chap-secrets. Currently, we have only test with no-auth

[Tokarak]

I agree, this needs tests. And: squashed.

[svlobanov]

PR with pppoe chap-secrets test: #191

[svlobanov]

@Tokarak I had to revert PR #190, I explained it there. For now, you can disable RADIUS during compile time and provide accel-ppp package in entware without radius support. usually entware is used for devices like home routers so most probably, most users don't need radius support like it's required in ISP. You will be able to enable radius in entware if musl-related issues are resolved in accel-pppd.

[Tokarak]

I am running Tokarak@b336d0d on my router right now, and auth works. I don't know what this means.

[svlobanov]

@Tokarak please share accel-pppd config, maybe you are using no-auth mode

[svlobanov]

could you please share accel-cmd show stat output?

[svlobanov]

you don't have any pppoe session, also I can see that accel-ppp tries radius to auth

[svlobanov]

maybe yesterday you run accel-pppd compiled without RADIUS

[Tokarak]

Could it work if chap_secrets was the favoured auth, overriding radius? Or whatever module was loaded last provides auth?