GCS custom download strategy can't find binaries in PATH

[husseinferas]

My custom download strategy

require "download_strategy"
require "open3"

def fetch_with_gsutil(gsutil_path:, bucket:, binary_path:, destination:)
  command = "#{gsutil_path} cp gs://#{bucket}/#{binary_path} #{destination}"
  stdout, stderr, status = Open3.capture3(command)

  if status.success?
    puts "Successfully downloaded: #{binary_path}"
  else
    puts "Error downloading #{binary_path}: #{stderr}"
    raise "Failed to download with gsutil. Exit status: #{status.exitstatus}"
  end
end

# Custom download strategy for GCS
class GcsDownloadStrategy < CurlDownloadStrategy
  def initialize(url, name, version, **meta)
    super
    @url = url
    @bucket, @binary_path = parse_gcs_url(url)
  end

  def parse_gcs_url(url)
    match = url.match(%r{^gs://([^/]+)/(.+)$})
    raise "Invalid GCS URL" unless match

    [match[1], match[2]]
  end

  def fetch(timeout: nil, **options)
    ohai "Downloading #{@binary_path} from GCS bucket #{@bucket}"
    binary_path = @binary_path
    bucket = @bucket
    destination = cached_location
    # This doesn't work with `gsutil` it need the full path for the binary, 
    # and the problem is, each user have different binary version for `gsutil`
    gsutil_path = "/opt/homebrew/bin/gsutil"

    fetch_with_gsutil(gsutil_path: gsutil_path, bucket: bucket, binary_path: binary_path, destination: destination)

  end
end

Output of brew install --formula -d -v --build-from-source ./Formula/lvh.rb

/opt/homebrew/Library/Homebrew/brew.rb (Formulary::FromPathLoader): loading /Users/hussein.firas/Projects/homebrew-tap/Formula/lvh.rb
==> Fetching lvh
==> Downloading lvh/v0.0.1/lvh_darwin_arm64.tar.gz from GCS bucket lh-homebrew-bin
/usr/bin/env /opt/homebrew/Library/Homebrew/shims/shared/curl --disable --cookie /dev/null --globoff --show-error --user-agent Homebrew/4.2.8\ \(Macintosh\;\ arm64\ Mac\ OS\ X\ 14.3.1\)\ curl/8.4.0 --header Accept-Language:\ en --retry 3 --fail --location --silent --head gs://lh-homebrew-bin/lvh/v0.0.1/lvh_darwin_arm64.tar.gz
Error: No such file or directory - gsutil
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/lib/ruby/3.1.0/open3.rb:222:in `spawn'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/lib/ruby/3.1.0/open3.rb:222:in `popen_run'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/lib/ruby/3.1.0/open3.rb:103:in `popen3'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/lib/ruby/3.1.0/open3.rb:290:in `capture3'
/Users/hussein.firas/Projects/homebrew-tap/Formula/lib/gcs_download_strategy.rb:6:in `fetch_with_gsutil'
/Users/hussein.firas/Projects/homebrew-tap/Formula/lib/gcs_download_strategy.rb:40:in `fetch'
/opt/homebrew/Library/Homebrew/downloadable.rb:87:in `fetch'
/opt/homebrew/Library/Homebrew/resource.rb:148:in `fetch'
/opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/lib/ruby/3.1.0/forwardable.rb:238:in `fetch'
/opt/homebrew/Library/Homebrew/formula.rb:2550:in `fetch'
/opt/homebrew/Library/Homebrew/formula_installer.rb:1237:in `fetch'
/opt/homebrew/Library/Homebrew/install.rb:277:in `block in install_formulae'
/opt/homebrew/Library/Homebrew/install.rb:247:in `map'
/opt/homebrew/Library/Homebrew/install.rb:247:in `install_formulae'
/opt/homebrew/Library/Homebrew/cmd/install.rb:295:in `install'
/opt/homebrew/Library/Homebrew/brew.rb:86:in `<main>'

Description of issue

I'm hosting the binary in the GCS bucket because I want to control the permissions in GCP. I've written this custom download strategy that runs gsutil command to download the binary, which works perfectly except for one breaking issue:
it can't find the gsutil binary unless we provide the full path for the binary, now this is a problem because the path for gsutil is different from one user to another, if you use brew to install gsutil, then it is predictable at /opt/homebrew/bin/gsutil but not all users use brew to in install it, in google docs it the users the freedom to choose the binary location
I've tried many methods and all of them didn't work

• tried to run the command /bin/bash -c 'gsutil cp ...'
• I tried to use which or where commands to find the binary
• I tried different methods to run commands like exec, system and command!
• I tried to pass env var for the bin location but didn't work

it looks like inside the download strategy it can't read the PATH for the user
I'm not a ruby expert so maybe I missed something obvious

Output of brew config

HOMEBREW_VERSION: 4.2.8
ORIGIN: https://github.com/Homebrew/brew
HEAD: eb7338abba43112e16e178d4329d5483d6d8fd6f
Last commit: 3 days ago
Core tap JSON: 15 Feb 10:15 UTC
Core cask tap JSON: 14 Feb 17:40 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 10
Homebrew Ruby: 3.1.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.1.4/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 15.0.0 build 1500
Git: 2.43.1 => /opt/homebrew/bin/git
Curl: 8.4.0 => /usr/bin/curl
macOS: 14.3.1-arm64
CLT: 15.1.0.0.1.1700200546
Xcode: N/A
Rosetta 2: false

[SMillerDev]

Brew filters out the path for almost all commands, since it would impact builds if you have a binary called curl in your path that actually starts Chrome. Therefore it'll be near impossible for brew to depend on things it doesn't know about.

[husseinferas]

is there a way to configure a path for brew? at least users can define the custom path gsutil and then it can find it during the installation
maybe passing an env var like HOMEBREW_CUSTOM_ENV...

[SMillerDev]

No, since it's intentionally clearing the path of non-brew influences. Your better choice is running something like /usr/bin/env bash -c 'which gsutil'

[husseinferas]

running bash -c 'which gsutil' give me no such file or directory error

[husseinferas]

I printed the /usr/bin/env and saw that the path is available; at which point did Brew drop the path?

[husseinferas]

I tried to capture the binary path in the initialize. I wanted to capture it in the early state before dropping the PATH but it didn't work