homebrew is stripping the 'v' off my cli #4589
Unanswered
claywd
asked this question in
Tap maintenance and brew development
Replies: 1 comment 3 replies
-
You can open a pull request: diff --git a/Formula/kubefirst.rb b/Formula/kubefirst.rb
index 3f83cf8c4fc..a4702752933 100644
--- a/Formula/kubefirst.rb
+++ b/Formula/kubefirst.rb
@@ -19,7 +19,7 @@ class Kubefirst < Formula
depends_on "go" => :build
def install
- ldflags = "-s -w -X github.com/kubefirst/runtime/configs.K1Version=#{version}"
+ ldflags = "-s -w -X github.com/kubefirst/runtime/configs.K1Version=v#{version}"
system "go", "build", *std_go_args(ldflags: ldflags)
generate_completions_from_executable(bin/"kubefirst", "completion")
@@ -30,6 +30,6 @@ class Kubefirst < Formula
assert_match "k1-paths:", (testpath/".kubefirst").read
assert_predicate testpath/".k1/logs", :exist?
- assert_match version.to_s, shell_output("#{bin}/kubefirst version")
+ assert_match "v#{version}", shell_output("#{bin}/kubefirst version")
end
end Use the commit message
(or similar) |
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Output of
brew config
Output of
brew doctor
Description of issue
So the version of our cli is currently v2.1.4 but homebrew is stripping off the
v
which is making the cli fail and telemetry fail. How do I update this formula to stop that from happening and keep thev
in the version? I've tried testing some different formula locally but it's made no difference thus far. I feel like it has something to do with the CI process that bumps versions which I've been unable to test locally.Any help or direction is appreciated.
To reproduce this issue,
brew install kubefirst
kubefirst version
Should show
kubefirst-cli golang utility version: v2.1.4
but instead it showskubefirst-cli golang utility version: 2.1.4
https://github.com/Homebrew/homebrew-core/blob/master/Formula/kubefirst.rb
Beta Was this translation helpful? Give feedback.
All reactions