Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ios] Crash in bookmarks #8089

Open
biodranik opened this issue May 5, 2024 · 3 comments
Open

[ios] Crash in bookmarks #8089

biodranik opened this issue May 5, 2024 · 3 comments
Assignees
@kirylkaveryn
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export iOS iOS development

Comments

@biodranik
Copy link
Member

The latest beta, looks like the bookmarks sorting is related. Wrong category ID? Could it be related to iCloud?

Incident Identifier: 335D7328-00DE-4A72-A625-2C6DB7C80062
Distributor ID:      com.apple.TestFlight
Hardware Model:      iPhone14,2
Process:             Organic Maps [8592]
Path:                /private/var/containers/Bundle/Application/7C277805-623F-4749-A960-8B853BE9F694/Organic Maps.app/Organic Maps
Identifier:          app.organicmaps
Version:             2024.04.29 (31.39020.3447)
AppStoreTools:       15E204
AppVariant:          1:iPhone14,2:17.4
Beta:                YES
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           app.organicmaps [2097]

Date/Time:           2024-05-01 18:46:31.7539 +0200
Launch Time:         2024-05-01 16:56:04.0254 +0200
OS Version:          iPhone OS 17.4.1 (21E236)
Release Type:        User
Baseband Version:    3.50.04
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: SIGNAL 6 Abort trap: 6
Terminating Process: Organic Maps [8592]

Triggered by Thread:  0


Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001e653e974 __pthread_kill + 8 (:-1)
1   libsystem_pthread.dylib       	0x00000001f9fc10ec pthread_kill + 268 (pthread.c:1717)
2   libsystem_c.dylib             	0x00000001a5f8fb80 abort + 180 (abort.c:118)
3   Organic Maps                  	0x000000010334d710 BookmarkManager::GetBmCategory(unsigned long long) const + 252 (bookmark_manager.hpp:586)
4   Organic Maps                  	0x0000000103357094 BookmarkManager::GetCategoryFileName(unsigned long long) const + 192 (bookmark_manager.cpp:1548)
5   Organic Maps                  	0x0000000103357094 BookmarkManager::GetMetadataEntryName(unsigned long long) const + 408 (bookmark_manager.cpp:1808)
6   Organic Maps                  	0x0000000103356a4c BookmarkManager::GetLastSortingType(unsigned long long, BookmarkManager::SortingType&) const + 256 (bookmark_manager.cpp:556)
7   Organic Maps                  	0x0000000103658ae8 -[MWMBookmarksManager hasLastSortingType:] + 36 (MWMBookmarksManager.mm:413)
8   Organic Maps                  	0x0000000102e3a0a4 BookmarksListInteractor.lastSortingType() + 80 (BookmarksListInteractor.swift:109)
9   Organic Maps                  	0x0000000102e147d8 protocol witness for IBookmarksListInteractor.lastSortingType() in conformance BookmarksListInteractor + 8 (<compiler-generated>:0)
10  Organic Maps                  	0x0000000102e147d8 BookmarksListPresenter.reload() + 52 (BookmarksListPresenter.swift:37)
11  Organic Maps                  	0x0000000102e179bc BookmarksListPresenter.viewDidLoad() + 116 (BookmarksListPresenter.swift:198)
12  Organic Maps                  	0x0000000102e7e9f4 protocol witness for IBookmarksListPresenter.viewDidLoad() in conformance BookmarksListPresenter + 8 (<compiler-generated>:0)
13  Organic Maps                  	0x0000000102e7e9f4 BookmarksListViewController.viewDidLoad() + 1520
14  Organic Maps                  	0x0000000102e7f004 @objc BookmarksListViewController.viewDidLoad() + 24 (<compiler-generated>:0)
15  UIKitCore                     	0x00000001a04b530c -[UIViewController _sendViewDidLoadWithAppearanceProxyObjectTaggingEnabled] + 84 (UIViewController.m:3029)
16  UIKitCore                     	0x00000001a026bfb4 -[UIViewController loadViewIfRequired] + 936 (UIViewController.m:4754)
17  UIKitCore                     	0x00000001a026a7a8 -[UIViewController view] + 24 (UIViewController.m:4776)
18  UIKitCore                     	0x00000001a095a384 -[UINavigationController _startCustomTransition:] + 1360 (UINavigationController.m:2246)
19  UIKitCore                     	0x00000001a036dca4 -[UINavigationController _startDeferredTransitionIfNeeded:] + 496 (UINavigationController.m:8062)
20  UIKitCore                     	0x00000001a036d3a0 -[UINavigationController __viewWillLayoutSubviews] + 96 (UINavigationController.m:8369)
21  UIKitCore                     	0x00000001a036d304 -[UILayoutContainerView layoutSubviews] + 172 (UILayoutContainerView.m:89)
22  UIKitCore                     	0x00000001a02890f8 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1528 (UIView.m:20041)
23  QuartzCore                    	0x000000019f6b3e30 CA::Layer::layout_if_needed(CA::Transaction*) + 504 (CALayer.mm:10816)
24  QuartzCore                    	0x000000019f6b39b4 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 148 (CALayer.mm:2598)
25  QuartzCore                    	0x000000019f6b9bb4 CA::Context::commit_transaction(CA::Transaction*, double, double*) + 464 (CAContextInternal.mm:2760)
26  QuartzCore                    	0x000000019f6b31bc CA::Transaction::commit() + 648 (CATransactionInternal.mm:432)
27  UIKitCore                     	0x00000001a0301280 _UIApplicationFlushCATransaction + 84 (UIApplication.m:3166)
28  UIKitCore                     	0x00000001a0300d78 _UIUpdateSequenceRun + 84 (_UIUpdateSequence.mm:119)
29  UIKitCore                     	0x00000001a0300468 schedulerStepScheduledMainSection + 144 (_UIUpdateScheduler.m:1037)
30  UIKitCore                     	0x00000001a0300524 runloopSourceCallback + 92 (_UIUpdateScheduler.m:1186)
31  CoreFoundation                	0x000000019e01162c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28 (CFRunLoop.c:1957)
32  CoreFoundation                	0x000000019e0108a8 __CFRunLoopDoSource0 + 176 (CFRunLoop.c:2001)
33  CoreFoundation                	0x000000019e00f058 __CFRunLoopDoSources0 + 244 (CFRunLoop.c:2038)
34  CoreFoundation                	0x000000019e00dd88 __CFRunLoopRun + 828 (CFRunLoop.c:2955)
35  CoreFoundation                	0x000000019e00d968 CFRunLoopRunSpecific + 608 (CFRunLoop.c:3420)
36  GraphicsServices              	0x00000001e23034e0 GSEventRunModal + 164 (GSEvent.c:2196)
37  UIKitCore                     	0x00000001a0480edc -[UIApplication _run] + 888 (UIApplication.m:3692)
38  UIKitCore                     	0x00000001a0480518 UIApplicationMain + 340 (UIApplication.m:5282)
39  Organic Maps                  	0x0000000102ec4ac8 main + 720 (main.mm:14)
40  dyld                          	0x00000001c152ed84 start + 2240 (dyldMain.cpp:1298)

crashlog.crash.zip
@biodranik biodranik added iOS iOS development Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export labels May 5, 2024
@rtsisyk
Copy link
Contributor

rtsisyk commented May 7, 2024 

#4	0x00000001032fb280 in BookmarkManager::GetBmCategory(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.hpp:586
#5	0x000000010330bbf8 in BookmarkManager::GetCategoryFileName(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.cpp:1548
#6	0x00000001032fffdc in BookmarkManager::GetMetadataEntryName(unsigned long long) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.cpp:1808
#7	0x00000001032ffda0 in BookmarkManager::GetLastSortingType(unsigned long long, BookmarkManager::SortingType&) const at /Users/roman/code/organicmaps/organicmaps/map/bookmark_manager.cpp:556
#8	0x0000000103d62148 in -[MWMBookmarksManager hasLastSortingType:] at /Users/roman/code/organicmaps/organicmaps/iphone/CoreApi/CoreApi/Bookmarks/MWMBookmarksManager.mm:413
#9	0x00000001023f69c0 in BookmarksListInteractor.lastSortingType() at /Users/roman/code/organicmaps/organicmaps/iphone/Maps/Bookmarks/BookmarksList/BookmarksListInteractor.swift:109
#10	0x00000001023f7058 in protocol witness for IBookmarksListInteractor.lastSortingType() in conformance BookmarksListInteractor ()
#11	0x00000001023a2340 in BookmarksListPresenter.reload() at /Users/roman/code/organicmaps/organicmaps/iphone/Maps/Bookmarks/BookmarksList/BookmarksListPresenter.swift:37
#12	0x00000001023a7b58 in BookmarksListPresenter.viewDidAppear() at /Users/roman/code/organicmaps/organicmaps/iphone/Maps/Bookmarks/BookmarksList/BookmarksListPresenter.swift:213
#13	0x00000001023ab4bc in protocol witness for IBookmarksListPresenter.viewDidAppear() in conformance BookmarksListPresenter ()
#14	0x0000000102489ce4 in BookmarksListViewController.viewDidAppear(_:) at /Users/roman/code/organicmaps/organicmaps/iphone/Maps/Bookmarks/BookmarksList/BookmarksListViewController.swift:56
#15	0x0000000102489d34 in @objc BookmarksListViewController.viewDidAppear(_:) ()
#16	0x000000019bc6a898 in -[UIViewController _setViewAppearState:isAnimating:] ()
#17	0x000000019bbdbd04 in -[UIViewController __viewDidAppear:] ()
#18	0x000000019bbdbc24 in -[UIViewController _endAppearanceTransition:] ()
#19	0x000000019bc48890 in -[UINavigationController navigationTransitionView:didEndTransition:fromView:toView:] ()
#20	0x000000019bc4839c in -[UINavigationTransitionView _notifyDelegateTransitionDidStopWithContext:] ()
#21	0x000000019bc481e8 in -[UINavigationTransitionView _cleanupTransition] ()
#22	0x000000019bc47f90 in +[UIView(UIViewAnimationWithBlocks) conditionallyAnimate:withAnimation:layout:completion:] ()
#23	0x000000019bc472b8 in -[UINavigationTransitionView transition:fromView:toView:] ()
#24	0x000000019bc46b10 in -[UINavigationController _startTransition:fromViewController:toViewController:] ()
#25	0x000000019bc45d14 in -[UINavigationController _startDeferredTransitionIfNeeded:] ()
#26	0x000000019bc453a0 in -[UINavigationController __viewWillLayoutSubviews] ()
#27	0x000000019bc45304 in -[UILayoutContainerView layoutSubviews] ()
#28	0x000000019bb610f8 in -[UIView(CALayerDelegate) layoutSublayersOfLayer:] ()
#29	0x000000019af8be30 in CA::Layer::layout_if_needed(CA::Transaction*) ()
#30	0x000000019af8b9b4 in CA::Layer::layout_and_display_if_needed(CA::Transaction*) ()
#31	0x000000019af91bb4 in CA::Context::commit_transaction(CA::Transaction*, double, double*) ()
#32	0x000000019af8b1bc in CA::Transaction::commit() ()
#33	0x000000019af8ae64 in CA::Transaction::flush_as_runloop_observer(bool) ()
#34	0x000000019bbd9260 in _UIApplicationFlushCATransaction ()
#35	0x000000019bbd8d78 in _UIUpdateSequenceRun ()
#36	0x000000019bbd8468 in schedulerStepScheduledMainSection ()
#37	0x000000019bbd8524 in runloopSourceCallback ()
#38	0x00000001998e962c in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#39	0x00000001998e88a8 in __CFRunLoopDoSource0 ()
#40	0x00000001998e7058 in __CFRunLoopDoSources0 ()
#41	0x00000001998e5d88 in __CFRunLoopRun ()
#42	0x00000001998e5968 in CFRunLoopRunSpecific ()
#43	0x00000001ddbdb4e0 in GSEventRunModal ()
#44	0x000000019bd58edc in -[UIApplication _run] ()
#45	0x000000019bd58518 in UIApplicationMain ()
#46	0x0000000102130170 in main at /Users/roman/code/organicmaps/organicmaps/iphone/Maps/main.mm:14
#47	0x00000001bce06d84 in start ()

@biodranik
Copy link
Member Author

The similar crash in the recent beta @kirylkaveryn :

Incident Identifier: 0A55B718-742C-41FF-BFC6-9DEB3197A64A
Distributor ID:      com.apple.TestFlight
Hardware Model:      iPhone14,4
Process:             Organic Maps [10077]
Path:                /private/var/containers/Bundle/Application/7BE160F5-0A2F-45A1-A8A0-21A62E2D49E4/Organic Maps.app/Organic Maps
Identifier:          app.organicmaps
Version:             2024.05.20 (15)
AppStoreTools:       15F31e
AppVariant:          1:iPhone14,4:17.4
Beta:                YES
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           app.organicmaps [1106]

Date/Time:           2024-05-20 17:19:43.5085 +0200
Launch Time:         2024-05-20 17:18:05.3912 +0200
OS Version:          iPhone OS 17.4.1 (21E236)
Release Type:        User
Baseband Version:    3.50.04
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: SIGNAL 6 Abort trap: 6
Terminating Process: Organic Maps [10077]

Triggered by Thread:  0


Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001ee332974 __pthread_kill + 8 (:-1)
1   libsystem_pthread.dylib       	0x0000000201db50ec pthread_kill + 268 (pthread.c:1717)
2   libsystem_c.dylib             	0x00000001add83b80 abort + 180 (abort.c:118)
3   Organic Maps                  	0x0000000104ac7c68 BookmarkManager::GetBmCategory(unsigned long long) const (in Organic Maps) (bookmark_manager.hpp:0) + 5880936
4   Organic Maps                  	0x0000000104ae6ea4 BookmarkManager::GetCategoryName(unsigned long long) const (in Organic Maps) (bookmark_manager.cpp:1512) + 6008484
5   Organic Maps                  	0x0000000104dd55f0 -[MWMBookmarksManager getCategoryName:] (in Organic Maps) (MWMBookmarksManager.mm:224) + 9082352
6   Organic Maps                  	0x0000000104dd2210 -[MWMBookmarkGroup title] (in Organic Maps) (MWMBookmarkGroup.m:24) + 9069072
7   Organic Maps                  	0x00000001045b81f4 BMCCategoryCell.categoryUpdated() (in Organic Maps) (BMCCategoryCell.swift:42) + 573940
8   Organic Maps                  	0x000000010455c83c BMCViewController.tableView(_:cellForRowAt:) (in Organic Maps) (<compiler-generated>:0) + 198716
9   Organic Maps                  	0x000000010455c9cc @objc BMCViewController.tableView(_:cellForRowAt:) (in Organic Maps) (<compiler-generated>:0) + 199116
10  UIKitCore                     	0x00000001a82cf864 -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 1348 (UITableView.m:16709)
11  UIKitCore                     	0x00000001a82cf29c -[UITableView _updateVisibleCellsForRanges:createIfNecessary:] + 596 (UITableView.m:3110)
12  UIKitCore                     	0x00000001a82cd7e8 -[UITableView _updateVisibleCellsNow:] + 1100 (UITableView.m:3252)
13  UIKitCore                     	0x00000001a82cd2d0 -[UITableView layoutSubviews] + 148 (UITableView.m:10679)
14  UIKitCore                     	0x00000001a807d0f8 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1528 (UIView.m:20041)
15  QuartzCore                    	0x00000001a74a7e30 CA::Layer::layout_if_needed(CA::Transaction*) + 504 (CALayer.mm:10816)
16  QuartzCore                    	0x00000001a74a79b4 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 148 (CALayer.mm:2598)
17  QuartzCore                    	0x00000001a74adbb4 CA::Context::commit_transaction(CA::Transaction*, double, double*) + 464

@kirylkaveryn
Copy link
Contributor

kirylkaveryn commented May 24, 2024 •
edited

The similar crash in the recent beta @kirylkaveryn :


Incident Identifier: 0A55B718-742C-41FF-BFC6-9DEB3197A64A

Distributor ID:      com.apple.TestFlight

Hardware Model:      iPhone14,4

Process:             Organic Maps [10077]

Path:                /private/var/containers/Bundle/Application/7BE160F5-0A2F-45A1-A8A0-21A62E2D49E4/Organic Maps.app/Organic Maps

Identifier:          app.organicmaps

Version:             2024.05.20 (15)

AppStoreTools:       15F31e

AppVariant:          1:iPhone14,4:17.4

Beta:                YES

Code Type:           ARM-64 (Native)

Role:                Foreground

Parent Process:      launchd [1]

Coalition:           app.organicmaps [1106]



Date/Time:           2024-05-20 17:19:43.5085 +0200

Launch Time:         2024-05-20 17:18:05.3912 +0200

OS Version:          iPhone OS 17.4.1 (21E236)

Release Type:        User

Baseband Version:    3.50.04

Report Version:      104



Exception Type:  EXC_CRASH (SIGABRT)

Exception Codes: 0x0000000000000000, 0x0000000000000000

Termination Reason: SIGNAL 6 Abort trap: 6

Terminating Process: Organic Maps [10077]



Triggered by Thread:  0





Thread 0 name:

Thread 0 Crashed:

0   libsystem_kernel.dylib        	0x00000001ee332974 __pthread_kill + 8 (:-1)

1   libsystem_pthread.dylib       	0x0000000201db50ec pthread_kill + 268 (pthread.c:1717)

2   libsystem_c.dylib             	0x00000001add83b80 abort + 180 (abort.c:118)

3   Organic Maps                  	0x0000000104ac7c68 BookmarkManager::GetBmCategory(unsigned long long) const (in Organic Maps) (bookmark_manager.hpp:0) + 5880936

4   Organic Maps                  	0x0000000104ae6ea4 BookmarkManager::GetCategoryName(unsigned long long) const (in Organic Maps) (bookmark_manager.cpp:1512) + 6008484

5   Organic Maps                  	0x0000000104dd55f0 -[MWMBookmarksManager getCategoryName:] (in Organic Maps) (MWMBookmarksManager.mm:224) + 9082352

6   Organic Maps                  	0x0000000104dd2210 -[MWMBookmarkGroup title] (in Organic Maps) (MWMBookmarkGroup.m:24) + 9069072

7   Organic Maps                  	0x00000001045b81f4 BMCCategoryCell.categoryUpdated() (in Organic Maps) (BMCCategoryCell.swift:42) + 573940

8   Organic Maps                  	0x000000010455c83c BMCViewController.tableView(_:cellForRowAt:) (in Organic Maps) (<compiler-generated>:0) + 198716

9   Organic Maps                  	0x000000010455c9cc @objc BMCViewController.tableView(_:cellForRowAt:) (in Organic Maps) (<compiler-generated>:0) + 199116

10  UIKitCore                     	0x00000001a82cf864 -[UITableView _createPreparedCellForGlobalRow:withIndexPath:willDisplay:] + 1348 (UITableView.m:16709)

11  UIKitCore                     	0x00000001a82cf29c -[UITableView _updateVisibleCellsForRanges:createIfNecessary:] + 596 (UITableView.m:3110)

12  UIKitCore                     	0x00000001a82cd7e8 -[UITableView _updateVisibleCellsNow:] + 1100 (UITableView.m:3252)

13  UIKitCore                     	0x00000001a82cd2d0 -[UITableView layoutSubviews] + 148 (UITableView.m:10679)

14  UIKitCore                     	0x00000001a807d0f8 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 1528 (UIView.m:20041)

15  QuartzCore                    	0x00000001a74a7e30 CA::Layer::layout_if_needed(CA::Transaction*) + 504 (CALayer.mm:10816)

16  QuartzCore                    	0x00000001a74a79b4 CA::Layer::layout_and_display_if_needed(CA::Transaction*) + 148 (CALayer.mm:2598)

17  QuartzCore                    	0x00000001a74adbb4 CA::Context::commit_transaction(CA::Transaction*, double, double*) + 464

Thanks! Seems like this beta contains not the latest icloud version that I pushed... I've updated the branch several times that day - it's my mistake.
This bug is fixed in the current icloud branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirylkaveryn kirylkaveryn

Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX import or export iOS iOS development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@biodranik @rtsisyk @kirylkaveryn