Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bookmark] Make color of icon only once for a list of bookmarks #5622

Open
dpriskorn opened this issue Jul 29, 2023 · 13 comments
Open

[bookmark] Make color of icon only once for a list of bookmarks #5622

dpriskorn opened this issue Jul 29, 2023 · 13 comments
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export Duplicate This issue or pull request already exists Raw Idea An idea that needs to be elaborated UI User interface issues

Comments

@dpriskorn
Copy link

Is your feature request related to a problem? Please describe.
When creating a new bookmark I want it to automatically get the same color icon ad all the others in the same list
Now I have to remember and choose the right color each time which is annoying.

Describe the solution you would like
Make icon color a property of the list and don't make me think about it when creating a bookmark.

Describe alternatives you have considered

Additional context

@biodranik
Copy link
Member

Now the next created bookmark should have the same color as a previous bookmark and should go into the same last used list. Doesn't it solve your issue?

@foersterp
Copy link

I've got the same problem. For example, when I have a list with places I want to go and another list with stuff I want to edit in OSM. Right now, I have to select the list, say OSM, and then the corresponding color. It would be handier if the color was chosen automatically. Then I want to add something to the other list. I have to choose the list and, unnecessarily, the color, manually again.

@d4f5409d
Copy link
Contributor

d4f5409d commented Aug 4, 2023

I guess it should looks something like this:

Lists menu ->

List 1, List 2

  • List 1 -> List settings ->

Color -> Blue,
Description -> Interesting
  • List 2 -> List settings ->

Color -> Red,
Description -> See it again

Saving bookmark 1 -> List selector dialog -> List1

The bookmark will appear as the previously configured one in the List settings (ex. Blue color and description "Interesting"

Saving bookmark 2 - List selector
dialog -> List 2

Bookmark 2 has red color and the description "See it again".

@biodranik
Copy link
Member

biodranik commented Aug 5, 2023

Complicated bookmark saving is not an option. Now it's done in one click. Doing it in more than one click breaks the UX.

Always using list colors also breaks existing UX of using the last color/last list.

Is there a solution that doesn't break the existing UX?

@d4f5409d
Copy link
Contributor

d4f5409d commented Aug 5, 2023

Complicated bookmark saving is not an option. Now it's done in one click. Doing it in more than one click breaks the UX.

Always using list colors also breaks existing UX of using the last color/last list.

Is there a solution that doesn't break the existing UX?

Don't know for sure, what I know sure that the current implementation is bad, that we have to select it everytime we create bookmarks if we have multiple lists. I don't think my suggestion would break UX that much, and I think others would also benefit from it and enjoy it.

@d4f5409d
Copy link
Contributor

d4f5409d commented Aug 5, 2023

Talking about UX, what guidelines do you follow to decide whether it breaks it or not? @biodranik

@biodranik
Copy link
Member

When millions of users are using it for many years, changing UX is not an easy thing.

Current flow allows easily add bookmarks of the same color into the same list. To start adding bookmarks to a different list with a different color user needs to edit bookmark and change its list and color once.

@d4f5409d
Copy link
Contributor

Screenshot_2023-08-12-21-47-55-38_320a9a695de7cdce83ed5281148d6f19.jpg

#1060

I am not sure why you are against it, and I am sure you are wrong about this one looking at the community feedback. I think OM is being held back by these decisions. Don't get me wrong, I am really glad about your effort and responsiveness when it comes to implementing new things, but let's try to be open. Maybe we just misunderstood each other (which is a common problem here sadly) and I will make sure to do a concept art to make sure you see what we mean by that feature.

@biodranik
Copy link
Member

I've exactly described my concerns about breaking the existing UX. I'm not against new features. I'm against making product more complex to use for the majority of users.
Please propose a balanced solution.

@d4f5409d
Copy link
Contributor

d4f5409d commented Aug 12, 2023

I guess then let's wait for the concept art and we can continue after that because I have ideas. Sorry if I did hurt you, I am a bit tired now, I shouldn't work when I am I know I know, but I thought if I'm still awake I make some contributions via discussing.

@biodranik
Copy link
Member

Great! It would be nice to have all scenarios covered there.

@salad612
Copy link

salad612 commented Oct 5, 2023

Complicated bookmark saving is not an option. Now it's done in one click. Doing it in more than one click breaks the UX.

Always using list colors also breaks existing UX of using the last color/last list.

Is there a solution that doesn't break the existing UX?

Another way could be to add an option in the hamburger menu of the list that lets you apply one color to all the existing bookmarks in the list at once.

A multi select that would let you move to another list or change color of multiple items would be even better but that is off topic.

Also i'll just link a related topic here for reference sake. #1805

@patepelo patepelo added Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export Raw Idea An idea that needs to be elaborated UI User interface issues labels Nov 8, 2023
@pastk
Copy link
Contributor

pastk commented Jun 3, 2024

A solution that doesn't break the current UX is described in #1805

Feel free to re-open this issue if you think its different.

@pastk pastk added the Duplicate This issue or pull request already exists label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bookmarks and Tracks Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export Duplicate This issue or pull request already exists Raw Idea An idea that needs to be elaborated UI User interface issues
Projects
None yet
Development

No branches or pull requests

7 participants