Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes from 6d2a4aa60e55f it makes it hard to diff against codespell defualt dictionary #8

Open
luzpaz opened this issue Oct 3, 2019 · 1 comment

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Oct 3, 2019

...and the fixes IMO are wrong.
In 6d2a4aa many fixes have been made that don't make sense. When codespell is run in autocorrect mode (codespell -q 3 -w) codespell will use the first word entry as the solution. For this reason, this first recommended fix should be the highest likely typo that is being made here. Example:
What in your opinion, looking at a QWERTY keyboard, was the intended word the user was trying to write?

alwas->always, alias,
alwas->alias, always,

it's obviously always, right?
Now, there are many times when this is open to interpretation. But the above example is the highest probability.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 3, 2019

Another point, is that this commit breaks a lot of compatibility with upstream's default dictionary and makes it hard to diff against

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant