Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull changes from codespell dictionary? #13

Open
luzpaz opened this issue Oct 13, 2019 · 6 comments
Open

Pull changes from codespell dictionary? #13

luzpaz opened this issue Oct 13, 2019 · 6 comments

Comments

@luzpaz
Copy link
Collaborator

luzpaz commented Oct 13, 2019

Is this not happening anymore?

@orbitcowboy
Copy link
Owner

Yes, you can do this by executing https://github.com/orbitcowboy/codespell_dictionary/blob/master/importFromCodespell.sh
I am doing this in regular intervals. But feel free to do it yourself :-)

@orbitcowboy
Copy link
Owner

Could you give it a try an import data from codespell? I was working on it recently

da85229

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 14, 2019

yea.. will try very soon.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 16, 2019

Just ran it, it tries add a ton of duplicates

Here are the different usecases:

  • codespell tries to overwrite a valid orbitcowboy single string result

  • codespell tries to overwrite a valid orbitcowboy mutli-string result:

    +absoluve->absolute
    absoluve->absolve, absolute,
  • codespell is correct and has just re-arranged results

     actuall->actual, actually,
    +actuall->actually, actual,

@orbitcowboy
Copy link
Owner

Yes, thats indeed a problem. We have to improve the script in order to reliably import data from codespell.

@luzpaz
Copy link
Collaborator Author

luzpaz commented Oct 16, 2019

I bet we could grab the tests that are done in the TravisCI and customize those scripts. Though coding is not my jam, so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants