Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'SUPPRESS_LABEL_WARNING' flag not working for false value #900

Open
GanziDaeyong opened this issue Feb 4, 2025 · 2 comments · May be fixed by #901
Open

'SUPPRESS_LABEL_WARNING' flag not working for false value #900

GanziDaeyong opened this issue Feb 4, 2025 · 2 comments · May be fixed by #901

Comments

@GanziDaeyong
Copy link

Hi. I've found that in the latest version (v3.51.6), the suppress label warning flag doesn't seem to work when set to false.

to reproduce the issue: Set the environment variable SUPPRESS_LABEL_WARNING to 'False' or any value other than 'True'.

@GanziDaeyong GanziDaeyong linked a pull request Feb 4, 2025 that will close this issue
@anup-21
Copy link
Member

anup-21 commented Feb 5, 2025

Thanks for highlighting this , in case you don't want to use the env variable then unset the variable instead of setting it to false or any other value i.e. unset SUPPRESS_LABEL_WARNING

@GanziDaeyong
Copy link
Author

GanziDaeyong commented Feb 5, 2025

@anup-21 Thank you. Considering the consistency with the error message and the error suppressing pattern used in other parts of the code, I think it needs to be fixed, so I've submitted a PR. Could you please check it out when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants