Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.x: Implement worker node taints #754

Open
devoncrouse opened this issue Jun 27, 2023 · 2 comments
Open

5.x: Implement worker node taints #754

devoncrouse opened this issue Jun 27, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@devoncrouse
Copy link
Member

@tb137
Copy link

tb137 commented Jul 31, 2023

Hi @devoncrouse, can you tell me if taints is working now? I see some implementation was done - https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/c177189b4d44e0b1a41bae6e475b7b65b1e3c922/modules/workers/virtualnodepools.tf#L46:L53

However configuration is being ignored, then I try to use it with following example:

worker_pools = {
     n2-pool = {
      shape              = "VM.Standard.E4.Flex",
      ....
      taints = {
        dedicated = {
          value  = "observability",
          effect = "NoExecute"
        }
      }
    }
  }

Am I missing something?

@thpham
Copy link
Contributor

thpham commented Aug 28, 2023

Hello, I'm really interested in having this feature, but I fear that the current oci-terraform-provider doesn't support it given the following issue: oracle/terraform-provider-oci#1504

and terraform containerengine_node_pool doesn't have taints.

is there any ETA for having it available in the provider and not having to do hacks with cloud-init stuff ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants