Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Some improvements #489

Open
3 tasks
hmgaudecker opened this issue Mar 13, 2024 · 0 comments
Open
3 tasks

DOCS: Some improvements #489

hmgaudecker opened this issue Mar 13, 2024 · 0 comments

Comments

@hmgaudecker
Copy link
Member

hmgaudecker commented Mar 13, 2024

  • Add a docs improvement issues template

  • Explain what n_samples does in LikelihoodResult.se() (It says to look at the implementation of constraints, but glancing over it I cannot find anything there.

  • Make the warning about a missing seed more constructive in LikelihoodResult.se(). E.g., a core estimagic dev wrote some code that produces:

    estimagic/estimation/estimate_ml.py:429: 
    UserWarning: seed is set to None and constraints are transforming. 
    This leads to randomness in the result. To avoid random behavior, choose a
    non-None seed.
    

    and it took me quite some time to find out where it is coming from (pytask does not show more and it wasn't obvious to me that LikelihoodResult lives in estimate_ml.py. So I had initially thought this happens during the estimation phase... Would be enough to add that this needs to be done in .se() or .summary().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant