Utilize wizard in StorageViewComponent

The storage view component now has no own "opinion" on the display
order and grouping of steps anymore, but will merely reflect the wizard
configuration. Changes in the wizard are immediately reflected in the UI
as well. Selection of the right components was also extracted into the
storage registries.

Renamings of existing translations were in most cases avoided, by renaming wizard
steps according to existing translations.

This made it necessary to unify the instantiation of all components rendered
inside the storage view, which was relatively straight-forward for most of them.
The OAuthClientFormComponent was challenging, as there was one use case where it
needed to be initialized with a client that was not yet assigned to the storage.

Author: NobodysNightmare

modules/storages/app/common/storages/peripherals/nextcloud_registry.rb

@@ -58,7 +58,19 @@ module Peripherals
       end
 
       namespace("components") do
+        namespace("forms") do
+          register(:automatically_managed_folders, ::Storages::Admin::Forms::AutomaticallyManagedProjectFoldersFormComponent)
+          register(:general_information, ::Storages::Admin::Forms::GeneralInfoFormComponent)
+          register(:oauth_application, ::Storages::Admin::OAuthApplicationInfoCopyComponent)
+          register(:oauth_client, ::Storages::Admin::Forms::OAuthClientFormComponent)
+        end
+
         register(:setup_wizard, NextcloudStorageWizard)
+
+        register(:automatically_managed_folders, ::Storages::Admin::AutomaticallyManagedProjectFoldersInfoComponent)
+        register(:general_information, ::Storages::Admin::GeneralInfoComponent)
+        register(:oauth_application, ::Storages::Admin::OAuthApplicationInfoComponent)
+        register(:oauth_client, ::Storages::Admin::OAuthClientInfoComponent)
       end
 
       namespace("contracts") do

modules/storages/app/common/storages/peripherals/nextcloud_storage_wizard.rb

@@ -31,17 +31,19 @@
 module Storages
   module Peripherals
     class NextcloudStorageWizard < Wizard
-      step :general_info, completed_if: ->(storage) { storage.host.present? && storage.name.present? }
+      step :general_information, completed_if: ->(storage) { storage.host.present? && storage.name.present? }
 
       step :oauth_application,
+           section: :oauth_configuration,
            completed_if: ->(storage) { storage.oauth_application.present? },
            preparation: :prepare_oauth_application
 
       step :oauth_client,
+           section: :oauth_configuration,
            completed_if: ->(storage) { storage.oauth_client.present? },
            preparation: ->(storage) { storage.build_oauth_client }
 
-      step :automatically_managed_project_folders,
+      step :automatically_managed_folders,
            completed_if: ->(storage) { !storage.automatic_management_unspecified? },
            preparation: :prepare_storage_for_automatic_management_form
 

modules/storages/app/common/storages/peripherals/one_drive_registry.rb

@@ -52,7 +52,19 @@ module Peripherals
       end
 
       namespace("components") do
+        namespace("forms") do
+          register(:access_management, ::Storages::Admin::Forms::AccessManagementFormComponent)
+          register(:general_information, ::Storages::Admin::Forms::GeneralInfoFormComponent)
+          register(:oauth_client, ::Storages::Admin::Forms::OAuthClientFormComponent)
+          register(:redirect_uri, ::Storages::Admin::Forms::RedirectUriFormComponent)
+        end
+
         register(:setup_wizard, OneDriveStorageWizard)
+
+        register(:access_management, ::Storages::Admin::AccessManagementComponent)
+        register(:general_information, ::Storages::Admin::GeneralInfoComponent)
+        register(:oauth_client, ::Storages::Admin::OAuthClientInfoComponent)
+        register(:redirect_uri, ::Storages::Admin::RedirectUriComponent)
       end
 
       namespace("contracts") do

modules/storages/app/common/storages/peripherals/one_drive_storage_wizard.rb

@@ -31,17 +31,20 @@
 module Storages
   module Peripherals
     class OneDriveStorageWizard < Wizard
-      step :general_info, completed_if: ->(storage) { storage.name.present? }
+      step :general_information, completed_if: ->(storage) { storage.name.present? }
 
       step :access_management,
+           section: :access_management_section,
            completed_if: ->(storage) { !storage.automatic_management_unspecified? },
            preparation: :prepare_storage_for_access_management_form
 
       step :oauth_client,
+           section: :oauth_configuration,
            completed_if: ->(storage) { storage.oauth_client.present? },
            preparation: ->(storage) { storage.build_oauth_client }
 
       step :redirect_uri,
+           section: :oauth_configuration,
            completed_if: ->(storage) {
              storage.oauth_client&.created_at && storage.oauth_client.created_at < 3.seconds.ago # HACK HACK HACK
            }

modules/storages/app/components/storages/admin/forms/oauth_client_form_component.rb

@@ -33,18 +33,12 @@ class OAuthClientFormComponent < ApplicationComponent
     include OpPrimer::ComponentHelpers
     include OpTurbo::Streamable
 
-    attr_reader :storage
-    alias_method :oauth_client, :model
+    alias_method :storage, :model
 
     options in_wizard: false
 
     def self.wrapper_key = :storage_oauth_client_section
 
-    def initialize(oauth_client:, storage:, **)
-      super(oauth_client, **)
-      @storage = storage
-    end
-
     def form_url
       query = { continue_wizard: storage.id } if in_wizard
       admin_settings_storage_oauth_client_path(storage, query)
@@ -65,6 +59,10 @@ def storage_provider_credentials_instructions
 
     private
 
+    def oauth_client
+      options[:oauth_client] || storage.oauth_client
+    end
+
     def one_drive_integration_link(target: "_blank")
       href = ::OpenProject::Static::Links[:storage_docs][:one_drive_oauth_application][:href]
       render(Primer::Beta::Link.new(href:, target:)) { I18n.t("storages.instructions.one_drive.application_link_text") }

modules/storages/app/components/storages/admin/forms/redirect_uri_form_component.rb

@@ -33,18 +33,13 @@ class RedirectUriFormComponent < ApplicationComponent
     include OpPrimer::ComponentHelpers
     include OpTurbo::Streamable
 
-    attr_reader :storage
-    alias_method :oauth_client, :model
+    alias_method :storage, :model
+    delegate :oauth_client, to: :storage
 
     options in_wizard: false
 
     def self.wrapper_key = :storage_redirect_uri_section
 
-    def initialize(oauth_client:, storage:, **)
-      super(oauth_client, **)
-      @storage = storage
-    end
-
     def form_url
       query = { continue_wizard: storage.id } if in_wizard
       finish_setup_admin_settings_storage_oauth_client_path(storage, query)

modules/storages/app/components/storages/admin/oauth_application_info_component.rb

@@ -34,13 +34,8 @@ class OAuthApplicationInfoComponent < ApplicationComponent
     include OpTurbo::Streamable
     include StorageViewInformation
 
-    attr_reader :storage
-    alias_method :oauth_application, :model
-
-    def initialize(oauth_application:, storage:, **)
-      super(oauth_application, **)
-      @storage = storage
-    end
+    alias_method :storage, :model
+    delegate :oauth_application, to: :storage
 
     def self.wrapper_key = :storage_openproject_oauth_section
   end

modules/storages/app/components/storages/admin/oauth_application_info_copy_component.rb

@@ -33,16 +33,11 @@ class OAuthApplicationInfoCopyComponent < ApplicationComponent
     include OpTurbo::Streamable
     include OpPrimer::ComponentHelpers
 
-    attr_reader :storage
-    alias_method :oauth_application, :model
+    alias_method :storage, :model
+    delegate :oauth_application, to: :storage
 
     options in_wizard: false
 
-    def initialize(oauth_application:, storage:, **)
-      super(oauth_application, **)
-      @storage = storage
-    end
-
     def self.wrapper_key = :storage_openproject_oauth_section
 
     def oauth_application_details_link

modules/storages/app/components/storages/admin/oauth_client_info_component.rb

@@ -34,13 +34,8 @@ class OAuthClientInfoComponent < ApplicationComponent
     include OpTurbo::Streamable
     include StorageViewInformation
 
-    attr_reader :storage
-    alias_method :oauth_client, :model
-
-    def initialize(oauth_client:, storage:, **)
-      super(oauth_client, **)
-      @storage = storage
-    end
+    alias_method :storage, :model
+    delegate :oauth_client, to: :storage
 
     def self.wrapper_key = :storage_oauth_client_section
 

modules/storages/app/components/storages/admin/redirect_uri_component.rb

@@ -34,13 +34,8 @@ class RedirectUriComponent < ApplicationComponent
     include OpTurbo::Streamable
     include StorageViewInformation
 
-    attr_reader :storage
-    alias_method :oauth_client, :model
-
-    def initialize(oauth_client:, storage:, **)
-      super(oauth_client, **)
-      @storage = storage
-    end
+    alias_method :storage, :model
+    delegate :oauth_client, to: :storage
 
     def self.wrapper_key = :storage_redirect_uri_section