pyzfs: remove unimplemented libzfs_core functions from pyzfs

As per #9008, pyzfs implements and documents several functions that
would be very useful, but then try to call c functions in libzfs_core.
These functions do not exist in libzfs_core, and in the ~7 years of
ticket creation still do not exist in libzfs_core.

It seems unlikely that these functions will get implemented, though 2
years ago, ~5 years after that ticket lzc_get_props was implemented in
23a489a which enabled get properties in
pyzfs. Sadly the first thing the  pyzfs function for lzc_get_props does
is call _list, which cals lzc_list, which is not implmented. And the
functions to set or inherit properties are still missing.

Having these functions in pyzfs are misleading, footguns, and time
wasters when evaluating pyzfs.

Removing these functions from pyzfs means that _if_ these functions are
added in libzfs_core, then pyzfs will also need to re-implement these
functions. It's a shame, because these py functions have good
documentation and tests. Funny enough the tests are auto skipped if it
detects that the functions don't exist in libzfs_core.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: George Shammas <george@shamm.as>
Closes #9008
Closes #18162

Author: georgyo

contrib/pyzfs/docs/source/index.rst

@@ -25,8 +25,7 @@ Documentation for the libzfs_core
 
 .. automodule:: libzfs_core
    :members:
-   :exclude-members: lzc_snap, lzc_recv, lzc_destroy_one,
-       lzc_inherit, lzc_set_props, lzc_list
+   :exclude-members: lzc_snap, lzc_recv, lzc_destroy_one
 
 Documentation for the libzfs_core exceptions
 ********************************************

contrib/pyzfs/libzfs_core/__init__.py

@@ -90,11 +90,6 @@
     lzc_snap,
     lzc_rename,
     lzc_destroy,
-    lzc_inherit_prop,
-    lzc_get_props,
-    lzc_set_props,
-    lzc_list_children,
-    lzc_list_snaps,
     receive_header,
 )
 
@@ -146,11 +141,6 @@
     'lzc_snap',
     'lzc_rename',
     'lzc_destroy',
-    'lzc_inherit_prop',
-    'lzc_get_props',
-    'lzc_set_props',
-    'lzc_list_children',
-    'lzc_list_snaps',
     'receive_header',
 ]
 

contrib/pyzfs/libzfs_core/_error_translation.py

@@ -638,64 +638,6 @@ def lzc_destroy_translate_error(ret, name):
     raise _generic_exception(ret, name, "Failed to destroy dataset")
 
 
-def lzc_inherit_prop_translate_error(ret, name, prop):
-    if ret == 0:
-        return
-    if ret == errno.EINVAL:
-        _validate_fs_name(name)
-        raise lzc_exc.PropertyInvalid(prop)
-    if ret == errno.ENOENT:
-        raise lzc_exc.DatasetNotFound(name)
-    raise _generic_exception(ret, name, "Failed to inherit a property")
-
-
-def lzc_set_prop_translate_error(ret, name, prop, val):
-    if ret == 0:
-        return
-    if ret == errno.EINVAL:
-        _validate_fs_or_snap_name(name)
-        raise lzc_exc.PropertyInvalid(prop)
-    if ret == errno.ENOENT:
-        raise lzc_exc.DatasetNotFound(name)
-    raise _generic_exception(ret, name, "Failed to set a property")
-
-
-def lzc_get_props_translate_error(ret, name):
-    if ret == 0:
-        return
-    if ret == errno.EINVAL:
-        _validate_fs_or_snap_name(name)
-    if ret == errno.ENOENT:
-        raise lzc_exc.DatasetNotFound(name)
-    raise _generic_exception(ret, name, "Failed to get properties")
-
-
-def lzc_list_children_translate_error(ret, name):
-    if ret == 0:
-        return
-    if ret == errno.EINVAL:
-        _validate_fs_name(name)
-    raise _generic_exception(ret, name, "Error while iterating children")
-
-
-def lzc_list_snaps_translate_error(ret, name):
-    if ret == 0:
-        return
-    if ret == errno.EINVAL:
-        _validate_fs_name(name)
-    raise _generic_exception(ret, name, "Error while iterating snapshots")
-
-
-def lzc_list_translate_error(ret, name, opts):
-    if ret == 0:
-        return
-    if ret == errno.ENOENT:
-        raise lzc_exc.DatasetNotFound(name)
-    if ret == errno.EINVAL:
-        _validate_fs_or_snap_name(name)
-    raise _generic_exception(ret, name, "Error obtaining a list")
-
-
 def _handle_err_list(ret, errlist, names, exception, mapper):
     '''
     Convert one or more errors from an operation into the requested exception.