@@ -89,18 +89,16 @@ func (c *TunnelHandler) Handler() error {
89
89
// try to update public IP if empty.
90
90
gw := & gws .Items [i ]
91
91
if ep := getTunnelActiveEndpoints (gw ); ep != nil {
92
- if ep .PublicIP == "" || c .natTraversal && (ep .NATType == "" || ep .PublicPort == 0 && ep .NATType != utils .NATSymmetric ) {
93
- if ep .PublicIP == "" {
94
- if err := c .configGatewayPublicIP (gw ); err != nil {
95
- klog .ErrorS (err , "error config gateway public ip" , "gateway" , klog .KObj (gw ))
96
- }
92
+ if ep .PublicIP == "" {
93
+ if err := c .configGatewayPublicIP (gw ); err != nil {
94
+ // output only error messages, without skipping
95
+ klog .ErrorS (err , "error config gateway public ip" , "gateway" , klog .KObj (gw ))
97
96
}
98
- if c . natTraversal && ( ep . NATType == "" || ep . PublicPort == 0 && ep . NATType != utils . NATSymmetric ) {
99
- if err := c . configGatewayStunInfo ( gw ); err != nil {
100
- klog . ErrorS ( err , "error config gateway stun info" , "gateway" , klog . KObj (gw ))
101
- }
97
+ }
98
+ if c . natTraversal && ( ep . NATType == "" || ep . PublicPort == 0 && ep . NATType != utils . NATSymmetric ) {
99
+ if err := c . configGatewayStunInfo (gw ); err != nil {
100
+ klog . ErrorS ( err , "error config gateway stun info" , "gateway" , klog . KObj ( gw ))
102
101
}
103
- continue
104
102
}
105
103
}
106
104
if ! c .shouldHandleGateway (gw ) {
@@ -212,10 +210,6 @@ func (c *TunnelHandler) shouldHandleGateway(gateway *v1beta1.Gateway) bool {
212
210
klog .InfoS ("no active endpoint , waiting for sync" , "gateway" , klog .KObj (gateway ))
213
211
return false
214
212
}
215
- if ep .PublicIP == "" {
216
- klog .InfoS ("no public IP for gateway, waiting for sync" , "gateway" , klog .KObj (gateway ))
217
- return false
218
- }
219
213
if c .natTraversal {
220
214
if ep .NATType == "" {
221
215
klog .InfoS ("no nat type for gateway, waiting for sync" , "gateway" , klog .KObj (gateway ))
0 commit comments