Skip to content

Commit 202f141

Browse files
committed
[BACKEND] Update LLVM version to llvm/llvm-project@7a33569
1 parent a44f72a commit 202f141

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

cmake/llvm-hash.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
570885128351868c1308bb22e8ca351d318bc4a1
1+
7a33569510535f0b917a2e50f644bf57490aee24

include/triton/Conversion/TritonGPUToLLVM/PatternTritonGPUOpToLLVM.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ void populateSPMDOpToLLVMPattern(LLVMTypeConverter &typeConverter,
9595
void populateFuncOpConversionPattern(LLVMTypeConverter &typeConverter,
9696
RewritePatternSet &patterns,
9797
const TargetInfoBase &targetInfo,
98-
PatternBenefit benefit);
98+
PatternBenefit benefit,
99+
SymbolTableCollection *symbolTables);
99100

100101
void populatePrintOpToLLVMPattern(LLVMTypeConverter &typeConverter,
101102
RewritePatternSet &patterns,

lib/Conversion/TritonGPUToLLVM/FuncOpToLLVM.cpp

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ using namespace mlir::triton;
2727
/// information.
2828
struct FuncOpConversion : public ConvertOpToLLVMPattern<triton::FuncOp> {
2929
FuncOpConversion(LLVMTypeConverter &converter,
30-
const TargetInfoBase &targetInfo, PatternBenefit benefit)
31-
: ConvertOpToLLVMPattern(converter, benefit), targetInfo(targetInfo) {}
30+
const TargetInfoBase &targetInfo, PatternBenefit benefit,
31+
SymbolTableCollection *symbolTables)
32+
: ConvertOpToLLVMPattern(converter, benefit), targetInfo(targetInfo),
33+
symbolTables(symbolTables) {}
3234

3335
/// Only retain those attributes that are not constructed by
3436
/// `LLVMFuncOp::build`. If `filterArgAttrs` is set, also filter out argument
@@ -146,7 +148,7 @@ struct FuncOpConversion : public ConvertOpToLLVMPattern<triton::FuncOp> {
146148

147149
FailureOr<LLVM::LLVMFuncOp> maybeNewFuncOp =
148150
mlir::convertFuncOpToLLVMFuncOp(amendedFuncOp, rewriter,
149-
*getTypeConverter());
151+
*getTypeConverter(), symbolTables);
150152
if (failed(maybeNewFuncOp)) {
151153
return failure();
152154
}
@@ -196,12 +198,16 @@ struct FuncOpConversion : public ConvertOpToLLVMPattern<triton::FuncOp> {
196198

197199
private:
198200
const TargetInfoBase &targetInfo;
201+
// Store a pointer to the single, pass-wide symbol table
202+
SymbolTableCollection *symbolTables;
199203
};
200204

201205
} // namespace
202206

203207
void mlir::triton::populateFuncOpConversionPattern(
204208
LLVMTypeConverter &typeConverter, RewritePatternSet &patterns,
205-
const TargetInfoBase &targetInfo, PatternBenefit benefit) {
206-
patterns.add<FuncOpConversion>(typeConverter, targetInfo, benefit);
209+
const TargetInfoBase &targetInfo, PatternBenefit benefit,
210+
SymbolTableCollection *symbolTables) {
211+
patterns.add<FuncOpConversion>(typeConverter, targetInfo, benefit,
212+
symbolTables);
207213
}

third_party/amd/lib/TritonAMDGPUToLLVM/TritonGPUToLLVM.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ struct ConvertTritonAMDGPUToLLVM
113113
TritonLLVMFunctionConversionTarget funcTarget(*context);
114114
RewritePatternSet funcPatterns(context);
115115
mlir::triton::populateFuncOpConversionPattern(
116-
typeConverter, funcPatterns, targetInfo, patternBenefitDefault);
116+
typeConverter, funcPatterns, targetInfo, patternBenefitDefault,
117+
/*symTable=*/nullptr);
117118
mlir::cf::populateControlFlowToLLVMConversionPatterns(typeConverter,
118119
funcPatterns);
119120
if (failed(

0 commit comments

Comments
 (0)