-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[24.10] Fix failing Python packages #27999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: openwrt-24.10
Are you sure you want to change the base?
Conversation
|
In case you're interested in the CI results only, it's faster to test in your fork. Since I assume there's some runner budget per org i.e. not enough runners for everybody, and you're unlikely to be building multiple kernel matrix workflows in parallel on your account. Unless that's what you're into 😅 |
|
Oooh, you are completely right. I did not think about it! 🙈👀 Thanks. |
|
I believe these changes will work but I suggest setting |
|
Okay, no issues. Will do that |
|
CI fail. Not really sure if that lowercase/uppercase is sensible at all. Looking at the main repo, quite a but portion has large cap starting things, and it doesn't bother me. Looks rather natural. |
c7ea6ed to
4ae4db6
Compare
Yeah,you are right. There were two solutions, @jefferyto. Added PYPI_SOURCE_NAME as requested. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
8fab260 to
7e0366a
Compare
|
Oh boy, this is going to be large. Several projects were updated as they are releasing new versions very often and on PyPI they uploaded it in lowercase. However, there are also some projects, which appears unmaintained. Build system is looking for lowercase, which is correct, but it can not find it as it is in uppercase and thus the CI/CD fails. I do have some fixes prepared and will push them shortly. |
1ff81cd to
7b3a7d6
Compare
Since setuptools 69.3.0, it supports PEP625, based on this, package name and as well, the wheel should used lowercase instead of uppercase and also dots (.) should use underscore (_) More details can be found here: https://discuss.python.org/t/amending-pep-427-and-pep-625-on-package-normalization-rules/17226 Fixes: ``` Successfully built flask-2.0.2-py3-none-any.whl Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/__main__.py", line 98, in <module> _main(sys.argv[1:], "python -m installer") File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/__main__.py", line 86, in _main with WheelFile.open(args.wheel) as source: File "/builder/shared-workdir/build/sdk/staging_dir/target-aarch64_cortex-a53_musl/usr/lib/python3.11/contextlib.py", line 137, in __enter__ return next(self.gen) ^^^^^^^^^^^^^^ File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/sources.py", line 162, in open with zipfile.ZipFile(path) as f: ^^^^^^^^^^^^^^^^^^^^^ File "/builder/shared-workdir/build/sdk/staging_dir/target-aarch64_cortex-a53_musl/usr/lib/python3.11/zipfile.py", line 1311, in __init__ self.fp = io.open(file, filemode) ^^^^^^^^^^^^^^^^^^^^^^^ FileNotFoundError: [Errno 2] No such file or directory: '/builder/shared-workdir/build/sdk/build_dir/target-aarch64_cortex-a53_musl/pypi/Flask-2.0.2//openwrt-build/Flask-2.0.2-*.whl' ``` Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://python-markdown.github.io/changelog/ Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://flask.palletsprojects.com/en/stable/changes/#version-2-3-3 Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://werkzeug.palletsprojects.com/en/stable/changes/#version-2-3-8 Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://github.com/python-pillow/Pillow/blob/10.2.0/CHANGES.rst Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://github.com/python-babel/babel/releases/tag/v2.15.0 Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://jinja.palletsprojects.com/en/stable/changes/#version-3-1-4 Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://github.com/pyca/pynacl/releases/tag/1.6.0 Signed-off-by: Josef Schlehofer <[email protected]>
Release notes: https://github.com/pyca/pyopenssl/releases/tag/24.2.1 Signed-off-by: Josef Schlehofer <[email protected]>
7b3a7d6 to
7be7031
Compare
Release notes: https://docs.sqlalchemy.org/en/20/changelog/changelog_20.html#change-2.0.35 Signed-off-by: Josef Schlehofer <[email protected]>
WIP