Skip to content

Conversation

@BKPepe
Copy link
Member

@BKPepe BKPepe commented Dec 2, 2025

WIP

@GeorgeSapkin
Copy link
Member

GeorgeSapkin commented Dec 2, 2025

In case you're interested in the CI results only, it's faster to test in your fork. Since I assume there's some runner budget per org i.e. not enough runners for everybody, and you're unlikely to be building multiple kernel matrix workflows in parallel on your account. Unless that's what you're into 😅

@BKPepe
Copy link
Member Author

BKPepe commented Dec 2, 2025

Oooh, you are completely right. I did not think about it! 🙈👀 Thanks.

@jefferyto
Copy link
Member

I believe these changes will work but I suggest setting PYPI_SOURCE_NAME instead of changing PYPI_NAME (for mostly pedantic reasons).

@BKPepe
Copy link
Member Author

BKPepe commented Dec 2, 2025

Okay, no issues. Will do that

@hnyman
Copy link
Contributor

hnyman commented Dec 2, 2025

CI fail.

Checking subject:
flask: Wheel name is not uppercase
[fail] First word after prefix in subject should not be capitalized

Not really sure if that lowercase/uppercase is sensible at all. Looking at the main repo, quite a but portion has large cap starting things, and it doesn't bother me. Looks rather natural.

Copilot AI review requested due to automatic review settings December 3, 2025 07:26
@BKPepe BKPepe force-pushed the fix-python-packages-24.10 branch from c7ea6ed to 4ae4db6 Compare December 3, 2025 07:26
@BKPepe
Copy link
Member Author

BKPepe commented Dec 3, 2025

I believe these changes will work but I suggest setting PYPI_SOURCE_NAME instead of changing PYPI_NAME (for mostly pedantic reasons).

Yeah,you are right. There were two solutions, @jefferyto.
I don't mind using any of these, however, PYPI_SOURCE_NAME, I was as the first most likely solution for this in #27747, but then I saw @commodo approach as well, when PYPI_NAME also works. 😇 And as some of these PYPI_NAME changes were already merged, I wanted to have it in sync, though.

Added PYPI_SOURCE_NAME as requested. :)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@BKPepe
Copy link
Member Author

BKPepe commented Dec 3, 2025

Oh boy, this is going to be large. Several projects were updated as they are releasing new versions very often and on PyPI they uploaded it in lowercase.

However, there are also some projects, which appears unmaintained. Build system is looking for lowercase, which is correct, but it can not find it as it is in uppercase and thus the CI/CD fails. I do have some fixes prepared and will push them shortly.

@BKPepe BKPepe force-pushed the fix-python-packages-24.10 branch 6 times, most recently from 1ff81cd to 7b3a7d6 Compare December 4, 2025 21:09
Since setuptools 69.3.0, it supports PEP625,
based on this, package name and as well,
the wheel should used lowercase instead of uppercase
and also dots (.) should use underscore (_)

More details can be found here:
https://discuss.python.org/t/amending-pep-427-and-pep-625-on-package-normalization-rules/17226

Fixes:
```
Successfully built flask-2.0.2-py3-none-any.whl
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/__main__.py", line 98, in <module>
    _main(sys.argv[1:], "python -m installer")
  File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/__main__.py", line 86, in _main
    with WheelFile.open(args.wheel) as source:
  File "/builder/shared-workdir/build/sdk/staging_dir/target-aarch64_cortex-a53_musl/usr/lib/python3.11/contextlib.py", line 137, in __enter__
    return next(self.gen)
           ^^^^^^^^^^^^^^
  File "/builder/shared-workdir/build/sdk/staging_dir/hostpkg/lib/python3.11/site-packages/installer/sources.py", line 162, in open
    with zipfile.ZipFile(path) as f:
         ^^^^^^^^^^^^^^^^^^^^^
  File "/builder/shared-workdir/build/sdk/staging_dir/target-aarch64_cortex-a53_musl/usr/lib/python3.11/zipfile.py", line 1311, in __init__
    self.fp = io.open(file, filemode)
              ^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/builder/shared-workdir/build/sdk/build_dir/target-aarch64_cortex-a53_musl/pypi/Flask-2.0.2//openwrt-build/Flask-2.0.2-*.whl'
```

Signed-off-by: Josef Schlehofer <[email protected]>
@BKPepe BKPepe force-pushed the fix-python-packages-24.10 branch from 7b3a7d6 to 7be7031 Compare December 6, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants